Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Fix testAllConstraints test #6817

Merged

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Mar 23, 2023

Description

Fix testAllConstraints test by using Math.ceil around mocked return values similar to what is used in code.

Issues Resolved

Resolves #6809

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…lculations as used in code

Signed-off-by: Suraj Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Mar 23, 2023
@dreamer-89 dreamer-89 merged commit e4d9fb5 into opensearch-project:main Mar 23, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2023
…lculations as used in code (#6817)

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit e4d9fb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Mar 23, 2023
…lculations as used in code (#6817) (#6818)

(cherry picked from commit e4d9fb5)

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
…lculations as used in code (opensearch-project#6817)

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Valentin Mitrofanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.cluster.routing.allocation.AllocationConstraintsTests.testAllConstraints is flaky
3 participants