Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node requirement for testPruneFileCacheOnIndexDeletion #6796

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

kotwanikunal
Copy link
Member

Description

  • Fixes test requirement for node type since local writable index is created which requires data node capabilities

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6796 (9a7a2fa) into main (f40fa82) will increase coverage by 0.12%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6796      +/-   ##
============================================
+ Coverage     70.75%   70.88%   +0.12%     
- Complexity    59230    59303      +73     
============================================
  Files          4810     4810              
  Lines        283487   283487              
  Branches      40877    40877              
============================================
+ Hits         200577   200936     +359     
+ Misses        66408    66101     -307     
+ Partials      16502    16450      -52     

see 457 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit 8ebd522)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Mar 23, 2023
…6808)

(cherry picked from commit 8ebd522)

Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
@kotwanikunal kotwanikunal deleted the snapshot-it branch July 12, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.snapshots.SearchableSnapshotIT.testPruneFileCacheOnIndexDeletion is flaky
4 participants