[BUG] Fix index create block getting applied when there is no data nodes healthy #6756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…althy Signed-off-by: Rishav Sagar <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
RS146BIJAY
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
RS146BIJAY
changed the title
gbbafna
approved these changes
Mar 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
…althy (#6756) Signed-off-by: Rishav Sagar <[email protected]> (cherry picked from commit e6a3700) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Mar 21, 2023
…althy (#6756) (#6771) (cherry picked from commit e6a3700) Signed-off-by: Rishav Sagar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl
pushed a commit
to mingshl/OpenSearch-Mingshl
that referenced
this pull request
Mar 24, 2023
…althy (opensearch-project#6756) Signed-off-by: Rishav Sagar <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
mitrofmep
pushed a commit
to mitrofmep/OpenSearch
that referenced
this pull request
Apr 5, 2023
…althy (opensearch-project#6756) Signed-off-by: Rishav Sagar <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug in which index create block gets applied when there are no healthy data nodes. In case when there is no healthy data nodes, DiskThresholdMonitor (running on ClusterManager nodes) applies index create block as all nodes (0) are above high watermark (0). This change fixes this issue by not applying index create block when there is no healthy data nodes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.