Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for custom block sized index inputs #6743

Closed

Conversation

kotwanikunal
Copy link
Member

Description

  • Adds in a node level configuration node.searchable_snapshot.block.size to enable block size tuning at node level for searchable snapshots
  • The configuration raises an exception if the block size is not defined as a power of 2 which is an internal constraint for the block manipulation logic

Issues Resolved

Resolves #6480

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation

@kotwanikunal
Copy link
Member Author

Whitesource failure fix is addressed by #6629

@andrross
Copy link
Member

Does this still work as expected if there are existing blocks on disk and then the node is restarted with a different block size setting?

@kotwanikunal
Copy link
Member Author

Does this still work as expected if there are existing blocks on disk and then the node is restarted with a different block size setting?

That will cause issues when recovering the cache at node boot. I was planning to wrap the exception and link to the API from #6030 .

@kotwanikunal
Copy link
Member Author

Changing the block size value for the node will lead to undesirable circumstances since we do not have a mechanism currently to migrate the existing blocks to the new block size.
We will need some persistent config through which we can figure out when the value is changed, and perform a migration or clear out the file cache.
Owing to the shortcomings as well as the nature of the config (used only for tuning), this feature will not be a part of the GA release for searchable snapshots.
This will be re-visited when we have these decisions ironed out.

#6480 (comment)

Closing out the PR in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Searchable Snapshots] Expose configuration option for block size
2 participants