-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed linelint and check EOL using spotless #6657
Removed linelint and check EOL using spotless #6657
Conversation
Signed-off-by: owaiskazi19 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: owaiskazi19 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6657 +/- ##
=========================================
Coverage 70.76% 70.76%
+ Complexity 59165 59162 -3
=========================================
Files 4803 4803
Lines 283188 283188
Branches 40837 40837
=========================================
+ Hits 200389 200396 +7
- Misses 66344 66362 +18
+ Partials 16455 16430 -25 see 491 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Added the |
Re-ran the windows precommit -
|
@@ -81,6 +82,12 @@ allprojects { | |||
paddedCell() | |||
} | |||
} | |||
format 'misc', { | |||
target '*.md', '*.gradle', '**/*.yaml', '**/*.yml', '**/*.svg' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, might want to audit the file extensions in this repo. I added .svg
over on SDK because we have them in some of our design docs, but not sure it's needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have svg here as well. Anyway, I feel it's good to have.
* Removed linelint and check EOL using spotless Signed-off-by: owaiskazi19 <[email protected]> * Removed json from misc Signed-off-by: owaiskazi19 <[email protected]> --------- Signed-off-by: owaiskazi19 <[email protected]> (cherry picked from commit dd6daab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Removed linelint and check EOL using spotless * Removed json from misc --------- (cherry picked from commit dd6daab) Signed-off-by: owaiskazi19 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Removed linelint and check EOL using spotless Signed-off-by: owaiskazi19 <[email protected]> * Removed json from misc Signed-off-by: owaiskazi19 <[email protected]> --------- Signed-off-by: owaiskazi19 <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
Description
Since Spotless can check for end of line, went ahead and removed the extra tool for checking EOL. Also, added misc files for spotless to format.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.