Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed linelint and check EOL using spotless #6657

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Mar 13, 2023

Description

Since Spotless can check for end of line, went ahead and removed the extra tool for checking EOL. Also, added misc files for spotless to format.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/12385/

* **CommitID:** [24bfceb](https://github.com/opensearch-project/OpenSearch/commit/24bfceb57ed02b993365292f20a5b3b9f84fb7a4)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#6658

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: owaiskazi19 <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6657 (c1c837f) into main (497c80d) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #6657   +/-   ##
=========================================
  Coverage     70.76%   70.76%           
+ Complexity    59165    59162    -3     
=========================================
  Files          4803     4803           
  Lines        283188   283188           
  Branches      40837    40837           
=========================================
+ Hits         200389   200396    +7     
- Misses        66344    66362   +18     
+ Partials      16455    16430   -25     

see 491 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Mar 13, 2023
@kotwanikunal
Copy link
Member

Added the backport 2.x label as well.

@kotwanikunal
Copy link
Member

Re-ran the windows precommit -

for C:\hostedtoolcache\windows\Java_Adopt_jdk\11.0.18-10\x64\bin\java.exe:[0.010s][warning][gc] Failed to reserve memory for new overflow mark stack with 4096 chunks and size 33554432B.
Error occurred during initialization of VM
Failed to allocate initial concurrent mark overflow mark stack.

@@ -81,6 +82,12 @@ allprojects {
paddedCell()
}
}
format 'misc', {
target '*.md', '*.gradle', '**/*.yaml', '**/*.yml', '**/*.svg'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, might want to audit the file extensions in this repo. I added .svg over on SDK because we have them in some of our design docs, but not sure it's needed here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have svg here as well. Anyway, I feel it's good to have.

@owaiskazi19 owaiskazi19 merged commit dd6daab into opensearch-project:main Mar 14, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 14, 2023
* Removed linelint and check EOL using spotless

Signed-off-by: owaiskazi19 <[email protected]>

* Removed json from misc

Signed-off-by: owaiskazi19 <[email protected]>

---------

Signed-off-by: owaiskazi19 <[email protected]>
(cherry picked from commit dd6daab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Mar 14, 2023
* Removed linelint and check EOL using spotless



* Removed json from misc



---------


(cherry picked from commit dd6daab)

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
* Removed linelint and check EOL using spotless

Signed-off-by: owaiskazi19 <[email protected]>

* Removed json from misc

Signed-off-by: owaiskazi19 <[email protected]>

---------

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants