Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to control auto release of OpenSearch Monitors managed index creation block #6277

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

RS146BIJAY
Copy link
Contributor

@RS146BIJAY RS146BIJAY commented Feb 9, 2023

Description

OpenSearch controls (applies and remove)create_index block (when all node are breaching high disk watermark) inside DiskThresholdMonitor. Now, if the user tries to apply this block from their end, it may be possible that DiskThresholdMonitor removes it (create_index gets removed if any of the node is not breaching high disk watermark). This makes this block to be usable only by OpenSearch monitors. User cannot control when these blocks get applied or removed.

We would suggest to add a configurable setting which will control when these blocks will be removed. This will ensure that when set to false, both user and OpenSearch monitor applies the respective blocks, but removal of the block is controlled by user.

Issues Resolved

#6269

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationStatsIT.testSegmentReplicationStatsResponse

@codecov-commenter
Copy link

Codecov Report

Merging #6277 (517a35d) into main (dfe5d2b) will increase coverage by 0.11%.
The diff coverage is 40.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6277      +/-   ##
============================================
+ Coverage     70.62%   70.73%   +0.11%     
- Complexity    58786    58861      +75     
============================================
  Files          4789     4789              
  Lines        281788   281795       +7     
  Branches      40669    40670       +1     
============================================
+ Hits         199007   199335     +328     
+ Misses        66412    66024     -388     
- Partials      16369    16436      +67     
Impacted Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...uster/routing/allocation/DiskThresholdMonitor.java 75.00% <25.00%> (-6.28%) ⬇️
...ster/routing/allocation/DiskThresholdSettings.java 92.90% <50.00%> (-1.73%) ⬇️
...pensearch/client/cluster/RemoteConnectionInfo.java 0.00% <0.00%> (-68.30%) ⬇️
...rch/test/junit/listeners/ReproduceInfoPrinter.java 9.52% <0.00%> (-68.26%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-58.83%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 42.50% <0.00%> (-48.75%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...nsearch/rest/action/cat/RestCatRecoveryAction.java 43.61% <0.00%> (-42.56%) ⬇️
... and 507 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search.aggregation/20_terms/string profiler via global ordinals}
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

Copy link
Collaborator

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM Rishav.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationStatsIT.testSegmentReplicationStatsResponse

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

CHANGELOG.md Outdated Show resolved Hide resolved
@RS146BIJAY RS146BIJAY changed the title Add a setting to control auto release of OpenSearch Monitors managed block Add a setting to control auto release of OpenSearch Monitors managed index creation block Feb 10, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@Bukhtawar Bukhtawar merged commit ca9c1ad into opensearch-project:main Feb 10, 2023
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Feb 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2023
…index creation block (#6277)

* Add a setting to control auto release of OpenSearch managed block

Signed-off-by: Rishav Sagar <[email protected]>
(cherry picked from commit ca9c1ad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Feb 11, 2023
…index creation block (#6277) (#6284)

* Add a setting to control auto release of OpenSearch managed block


(cherry picked from commit ca9c1ad)

Signed-off-by: Rishav Sagar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants