-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting to control auto release of OpenSearch Monitors managed index creation block #6277
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6277 +/- ##
============================================
+ Coverage 70.62% 70.73% +0.11%
- Complexity 58786 58861 +75
============================================
Files 4789 4789
Lines 281788 281795 +7
Branches 40669 40670 +1
============================================
+ Hits 199007 199335 +328
+ Misses 66412 66024 -388
- Partials 16369 16436 +67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
517a35d
to
06d769d
Compare
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM Rishav.
server/src/main/java/org/opensearch/cluster/routing/allocation/DiskThresholdSettings.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishav Sagar <[email protected]>
06d769d
to
ff479f5
Compare
...usterTest/java/org/opensearch/cluster/routing/allocation/decider/DiskThresholdDeciderIT.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
ff479f5
to
8f3416b
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishav Sagar <[email protected]>
8f3416b
to
a8957cc
Compare
Gradle Check (Jenkins) Run Completed with:
|
…index creation block (#6277) * Add a setting to control auto release of OpenSearch managed block Signed-off-by: Rishav Sagar <[email protected]> (cherry picked from commit ca9c1ad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…index creation block (#6277) (#6284) * Add a setting to control auto release of OpenSearch managed block (cherry picked from commit ca9c1ad) Signed-off-by: Rishav Sagar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
OpenSearch controls (applies and remove)
create_index
block (when all node are breaching high disk watermark) insideDiskThresholdMonitor
. Now, if the user tries to apply this block from their end, it may be possible thatDiskThresholdMonitor
removes it (create_index
gets removed if any of the node is not breaching high disk watermark). This makes this block to be usable only by OpenSearch monitors. User cannot control when these blocks get applied or removed.We would suggest to add a configurable setting which will control when these blocks will be removed. This will ensure that when set to false, both user and OpenSearch monitor applies the respective blocks, but removal of the block is controlled by user.
Issues Resolved
#6269
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.