[Extensions] Fix timeout error when adding a document to an index with extension running #6275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6275 +/- ##
============================================
+ Coverage 70.62% 70.77% +0.15%
- Complexity 58786 58891 +105
============================================
Files 4789 4789
Lines 281788 281789 +1
Branches 40669 40670 +1
============================================
+ Hits 199007 199437 +430
+ Misses 66412 65950 -462
- Partials 16369 16402 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
approved these changes
Feb 13, 2023
| if (e.getCause() instanceof TimeoutException) { | ||
| logger.info("No response from extension to request."); | ||
| } | ||
| if (e.getCause() instanceof RuntimeException) { |
There was a problem hiding this comment.
curious why this isn't an else if like line 512.
There was a problem hiding this comment.
Not sure - I should fix that
There was a problem hiding this comment.
Actually I think it's intentional, because no exception handling happens in the first if statement: there's only an additional logging statement. The other if/else ifs actually handle the exception.
There was a problem hiding this comment.
Ah, I see. A timeout is a runtime exception so we log and throw.
Signed-off-by: Ryan Bogan <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
reviewed
Feb 13, 2023
owaiskazi19
approved these changes
Feb 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
…h extension running (#6275) * Fix timeout error when adding a document to an index with extension running Signed-off-by: Ryan Bogan <[email protected]> * Add CHANGELOG entry Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit 0eee9a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli
pushed a commit
that referenced
this pull request
Feb 15, 2023
…h extension running (#6275) (#6307) * Fix timeout error when adding a document to an index with extension running (cherry picked from commit 0eee9a9) Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Bogan [email protected]
Description
Fixes a timeout exception that would occur when attempting to add a document to an index while an extension is running.
Issues Resolved
#5999
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.