Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SafeConstructor() instead of Constructor() #6205

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

andrross
Copy link
Member

@andrross andrross commented Feb 6, 2023

@ryanbogan @saratvemulapalli Can you verify if this okay? For reference, a similar change was made here: opensearch-project/security-analytics#198

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan
Copy link
Member

@andrross There is a test in ExtensionsManagerTests.java called testDiscover() that tests reading in from extensions.yml. As long as that test passes, the change should be fine.

@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit a5dc22a into opensearch-project:main Feb 6, 2023
@andrross andrross deleted the use-safeconstructor branch February 6, 2023 21:00
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit a5dc22a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Feb 6, 2023
(cherry picked from commit a5dc22a)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants