-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add support to run SegRep integ tests using remote store settings #6192
[Remote Store] Add support to run SegRep integ tests using remote store settings #6192
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
09e9453
to
a301daf
Compare
Gradle Check (Jenkins) Run Completed with:
|
Seeing intermittent issues with |
@@ -83,6 +84,9 @@ public RemoteFsTranslog( | |||
try { | |||
download(translogTransferManager, location); | |||
Checkpoint checkpoint = readCheckpoint(location); | |||
assert globalCheckpointSupplier instanceof ReplicationTracker | |||
: "globalCheckpointSupplier is not instance of ReplicationTracker"; | |||
((ReplicationTracker) globalCheckpointSupplier).updateGlobalCheckpoint(checkpoint.globalCheckpoint, "RemoteFsTranslog init"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this update should happen in IndexShard
instead of RemoteFsTranslog
. As part of recovery, we can download the translog files and update the replicationTracker's global checkpoint.
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
…ote translog Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
580bf9e
to
a675b53
Compare
Gradle Check (Jenkins) Run Completed with:
|
Closing this PR as created new one with refactored translog download flow: #6405 |
Signed-off-by: Sachin Kale [email protected]
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.