Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add support to run SegRep integ tests using remote store settings #6192

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Feb 6, 2023

Signed-off-by: Sachin Kale [email protected]

Description

  • We want to test various scenarios involving replica promotion, peer recovery, index close and re-open with remote store.
  • These scenarios are already being tested in various integ tests of Segment Replication.
  • In this change, we re-use the same tests by enabling remote store settings.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Gradle Check (Jenkins) Run Completed with:

@sachinpkale sachinpkale force-pushed the segrep-its-with-remote-store branch from 09e9453 to a301daf Compare February 7, 2023 07:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testIndexReopenClose

@sachinpkale
Copy link
Member Author

Seeing intermittent issues with org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testIndexReopenClose. Looking into it.

@@ -83,6 +84,9 @@ public RemoteFsTranslog(
try {
download(translogTransferManager, location);
Checkpoint checkpoint = readCheckpoint(location);
assert globalCheckpointSupplier instanceof ReplicationTracker
: "globalCheckpointSupplier is not instance of ReplicationTracker";
((ReplicationTracker) globalCheckpointSupplier).updateGlobalCheckpoint(checkpoint.globalCheckpoint, "RemoteFsTranslog init");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this update should happen in IndexShard instead of RemoteFsTranslog. As part of recovery, we can download the translog files and update the replicationTracker's global checkpoint.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Gradle Check (Jenkins) Run Completed with:

@sachinpkale sachinpkale force-pushed the segrep-its-with-remote-store branch from 580bf9e to a675b53 Compare February 8, 2023 10:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@sachinpkale
Copy link
Member Author

Closing this PR as created new one with refactored translog download flow: #6405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant