Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Update peer recovery logic for segment replication #5959

Merged

Conversation

dreamer-89
Copy link
Member

Backports #5344 to 2.x

…ion (opensearch-project#5344)

* [Segment Replication] Update peer recovery logic for segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Add integration test for indexing during relocation

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments

Signed-off-by: Suraj Singh <[email protected]>

* Spotless check apply fixes & one failing unit test

Signed-off-by: Suraj Singh <[email protected]>

* Delay force segment replication till relocation handoff

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

* Unit test fix

Signed-off-by: Suraj Singh <[email protected]>

* Address review comment, move force segrep sync handler to SegRepTargetService

Signed-off-by: Suraj Singh <[email protected]>

* Resolve conflicts and enabled tests

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5959 (9fd7bed) into 2.x (a25c6b7) will decrease coverage by 0.07%.
The diff coverage is 47.93%.

@@             Coverage Diff              @@
##                2.x    #5959      +/-   ##
============================================
- Coverage     70.52%   70.45%   -0.07%     
+ Complexity    58953    58941      -12     
============================================
  Files          4766     4767       +1     
  Lines        282437   282534      +97     
  Branches      41129    41136       +7     
============================================
- Hits         199199   199071     -128     
- Misses        66553    66824     +271     
+ Partials      16685    16639      -46     
Impacted Files Coverage Δ
.../opensearch/indices/recovery/ForceSyncRequest.java 0.00% <0.00%> (ø)
.../recovery/LocalStorePeerRecoverySourceHandler.java 81.60% <ø> (+0.92%) ⬆️
...rg/opensearch/indices/recovery/RecoveryTarget.java 72.51% <0.00%> (-0.43%) ⬇️
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <ø> (-100.00%) ⬇️
.../indices/recovery/RemoteRecoveryTargetHandler.java 89.55% <0.00%> (-10.45%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 83.23% <ø> (ø)
...ation/OpenSearchIndexLevelReplicationTestCase.java 90.10% <0.00%> (+0.24%) ⬆️
...s/replication/SegmentReplicationTargetService.java 50.72% <12.12%> (-12.14%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 70.54% <60.86%> (+0.39%) ⬆️
...org/opensearch/index/shard/IndexShardTestCase.java 93.45% <86.66%> (-0.57%) ⬇️
... and 491 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kotwanikunal kotwanikunal merged commit 4849f62 into opensearch-project:2.x Jan 20, 2023
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…ion (#5344) (#5959)

* [Segment Replication] Update peer recovery logic for segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Add integration test for indexing during relocation

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments

Signed-off-by: Suraj Singh <[email protected]>

* Spotless check apply fixes & one failing unit test

Signed-off-by: Suraj Singh <[email protected]>

* Delay force segment replication till relocation handoff

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

* Unit test fix

Signed-off-by: Suraj Singh <[email protected]>

* Address review comment, move force segrep sync handler to SegRepTargetService

Signed-off-by: Suraj Singh <[email protected]>

* Resolve conflicts and enabled tests

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>
@dreamer-89 dreamer-89 deleted the backport/backport-5344-to-2.x branch March 2, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants