Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Apply OpenSearchIntegTestCase::featureFlagSettings by default (#5940) #5944

Merged

Conversation

andrross
Copy link
Member

Backport 7a511dd from #5940

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

I'm going to wait for #5945 to be merged and then rebase this backport.

@dreamer-89
Copy link
Member

dreamer-89 commented Jan 20, 2023

I see last couple of gradle check failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test:framework:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

Looks like a legit failure. @andrross

> Task :test:framework:compileJava
/var/jenkins/workspace/gradle-check/search/test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java:1908: error: cannot find symbol
            .put(featureFlagSettings());
                 ^
  symbol:   method featureFlagSettings()
  location: class OpenSearchIntegTestCase

2: Task failed with an exception.

  • What went wrong:
    Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.

Building 2.4.1 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/bugfix/build/bwc/checkout-2.4/distribution/archives/linux-tar/build/distributions/opensearch-min-2.4.1-SNAPSHOT-linux-x64.tar.gz

  • Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
==============================================================================

3: Task failed with an exception.

  • What went wrong:
    Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.

Building 1.3.7 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.7-SNAPSHOT-linux-x64.tar.gz

This is failing because of version bump in 1.x from 1.3.7 -> 1.3.8. Would need same here. Raising PR for this.
Looks like https://github.com/andrross/OpenSearch/commits/backport/backport-5940-to-2.x is pretty old and needs rebase.

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @andrross for this change.

This is currently failing gradle check that should be fixed post rebase.

@andrross andrross force-pushed the backport/backport-5940-to-2.x branch 2 times, most recently from d4f458c to 6283fb3 Compare January 20, 2023 16:37
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross force-pushed the backport/backport-5940-to-2.x branch 2 times, most recently from b21b410 to 75c9134 Compare January 20, 2023 16:42
…arch-project#5940)

This commit applies any feature flags specified by a child class
override of the featureFlagSettings() method by default. The result is
that test implementations do not have to manually specify the
featureFlagSettings when creating test nodes.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 7a511dd)
@andrross andrross force-pushed the backport/backport-5940-to-2.x branch from 75c9134 to bf0bcc6 Compare January 20, 2023 16:43
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit d51dd7c into opensearch-project:2.x Jan 20, 2023
@andrross andrross deleted the backport/backport-5940-to-2.x branch January 20, 2023 18:12
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…#5944)

This commit applies any feature flags specified by a child class
override of the featureFlagSettings() method by default. The result is
that test implementations do not have to manually specify the
featureFlagSettings when creating test nodes.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 7a511dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants