-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Apply OpenSearchIntegTestCase::featureFlagSettings by default (#5940) #5944
[Backport 2.x] Apply OpenSearchIntegTestCase::featureFlagSettings by default (#5940) #5944
Conversation
e0078bc
to
8f4bce5
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
I'm going to wait for #5945 to be merged and then rebase this backport. |
I see last couple of gradle check failures.
Looks like a legit failure. @andrross
2: Task failed with an exception.
3: Task failed with an exception.
This is failing because of version bump in 1.x from 1.3.7 -> 1.3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @andrross for this change.
This is currently failing gradle check that should be fixed post rebase.
d4f458c
to
6283fb3
Compare
Gradle Check (Jenkins) Run Completed with:
|
b21b410
to
75c9134
Compare
…arch-project#5940) This commit applies any feature flags specified by a child class override of the featureFlagSettings() method by default. The result is that test implementations do not have to manually specify the featureFlagSettings when creating test nodes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 7a511dd)
75c9134
to
bf0bcc6
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…#5944) This commit applies any feature flags specified by a child class override of the featureFlagSettings() method by default. The result is that test implementations do not have to manually specify the featureFlagSettings when creating test nodes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 7a511dd)
Backport 7a511dd from #5940