Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x]Fix Graph Filter Error in Search (#5665) #5912

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

mingshl
Copy link
Contributor

@mingshl mingshl commented Jan 17, 2023

Manual create backport 1.x PR due to merge conflict at #5665

  • fix graph filter out of bound error

Signed-off-by: Mingshi Liu [email protected]

  • add changelog

Signed-off-by: Mingshi Liu [email protected]

Signed-off-by: Mingshi Liu [email protected]
(cherry picked from commit 6a7a9a1)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* fix graph filter out of bound error

Signed-off-by: Mingshi Liu <[email protected]>

* add changelog

Signed-off-by: Mingshi Liu <[email protected]>

* run gradle spotlessApply

Signed-off-by: Mingshi Liu <[email protected]>

* reproduce error in unit test

Signed-off-by: Mingshi Liu <[email protected]>

* format to pass spotlessApply

Signed-off-by: Mingshi Liu <[email protected]>

* organize package

Signed-off-by: Mingshi Liu <[email protected]>

Signed-off-by: Mingshi Liu <[email protected]>
(cherry picked from commit 6a7a9a1)
@mingshl mingshl requested a review from reta as a code owner January 17, 2023 21:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (39389e8) to head (b564f31).
Report is 106 commits behind head on 1.x.

Files with missing lines Patch % Lines
...n/java/org/opensearch/index/search/MatchQuery.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #5912      +/-   ##
============================================
+ Coverage     77.87%   77.89%   +0.02%     
+ Complexity    63453    63449       -4     
============================================
  Files          4454     4454              
  Lines        275053   275056       +3     
  Branches      41175    41176       +1     
============================================
+ Hits         214193   214265      +72     
+ Misses        44001    43871     -130     
- Partials      16859    16920      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit d1935d9 into opensearch-project:1.x Jan 18, 2023
@mingshl mingshl deleted the backport/backport-5665-to-1.x branch January 18, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants