Update nebula-publishing-plugin to 19.2.0 #5704

reta · 2023-01-04T20:25:52Z

Signed-off-by: Andriy Redko [email protected]

Description

Update nebula-publishing-plugin to 19.2.0

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-01-04T20:33:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8822/
CommitID: 6c6b09f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-01-04T20:48:29Z

@tlfeng FYI :)

github-actions · 2023-01-04T21:07:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8826/
CommitID: 4b4f4e8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-04T21:48:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8830/
CommitID: 1ed25d5
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-04T23:25:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8833/
CommitID: e6eafe3

Signed-off-by: Andriy Redko <[email protected]>

github-actions · 2023-01-05T14:05:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8885/
CommitID: ea512e3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-01-05T14:20:57Z

buildSrc/src/main/java/org/opensearch/gradle/PublishPlugin.java

@@ -108,8 +109,12 @@ public String call() throws Exception {
            // Here we manually add any project dependencies in the "shadow" configuration to our generated POM
            publication.getPom().withXml(xml -> {
                Node root = xml.asNode();
-                root.appendNode("name", project.getName());
-                root.appendNode("description", project.getDescription());
+                if (((NodeList) root.get("name")).isEmpty()) {


May conflict with com.netflix.nebula.maven-base-publish which adds name and description properties

github-actions · 2023-01-05T14:38:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testStartReplicaAfterPrimaryIndexesDocs

URL: https://build.ci.opensearch.org/job/gradle-check/8887/
CommitID: ea512e3
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov-commenter · 2023-01-05T14:40:04Z

Codecov Report

Merging #5704 (ea512e3) into main (28e9b11) will increase coverage by 0.08%.
The diff coverage is 56.66%.

@@             Coverage Diff              @@
##               main    #5704      +/-   ##
============================================
+ Coverage     70.98%   71.07%   +0.08%     
- Complexity    58669    58675       +6     
============================================
  Files          4763     4764       +1     
  Lines        279945   279969      +24     
  Branches      40418    40423       +5     
============================================
+ Hits         198731   198998     +267     
+ Misses        64988    64705     -283     
- Partials      16226    16266      +40

Impacted Files	Coverage Δ
.../opensearch/gradle/plugin/PluginBuildPlugin.groovy	`36.28% <0.00%> (ø)`
...a/org/opensearch/test/OpenSearchIntegTestCase.java	`56.35% <0.00%> (-0.32%)`	⬇️
...main/java/org/opensearch/gradle/PublishPlugin.java	`43.13% <33.33%> (-0.30%)`	⬇️
...pensearch/common/settings/FeatureFlagSettings.java	`50.00% <50.00%> (ø)`
.../java/org/opensearch/common/util/FeatureFlags.java	`80.00% <88.88%> (+30.00%)`	⬆️
.../java/org/opensearch/gradle/pluginzip/Publish.java	`11.62% <100.00%> (ø)`
...org/opensearch/common/settings/SettingsModule.java	`85.81% <100.00%> (+0.29%)`	⬆️
server/src/main/java/org/opensearch/node/Node.java	`87.17% <100.00%> (+0.01%)`	⬆️
...main/java/org/opensearch/ingest/ProcessorInfo.java	`21.05% <0.00%> (-47.37%)`	⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java	`27.77% <0.00%> (-41.67%)`	⬇️
... and 501 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mch2 · 2023-01-05T17:11:36Z

Muting this SR test - #5714

opensearch-trigger-bot · 2023-01-06T14:56:59Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5704-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b51bc5bead2fde9674f8f989a8a390f9ecfa451
# Push it to GitHub
git push --set-upstream origin backport/backport-5704-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5704-to-2.x.

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>

opensearch-trigger-bot · 2023-05-08T22:31:47Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-5704-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b51bc5bead2fde9674f8f989a8a390f9ecfa451
# Push it to GitHub
git push --set-upstream origin backport/backport-5704-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-5704-to-1.x.

opensearch-trigger-bot · 2023-05-08T22:32:36Z

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-5704-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b51bc5bead2fde9674f8f989a8a390f9ecfa451
# Push it to GitHub
git push --set-upstream origin backport/backport-5704-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-5704-to-1.3.

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 3b51bc5)

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 3b51bc5) Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 3b51bc5)

reta force-pushed the issue-5702 branch from 6c6b09f to 4b4f4e8 Compare January 4, 2023 20:48

reta force-pushed the issue-5702 branch from 4b4f4e8 to 1ed25d5 Compare January 4, 2023 21:41

reta force-pushed the issue-5702 branch from 1ed25d5 to e6eafe3 Compare January 4, 2023 22:58

Update nebula-publishing-plugin to 19.2.0

ea512e3

Signed-off-by: Andriy Redko <[email protected]>

reta force-pushed the issue-5702 branch from e6eafe3 to ea512e3 Compare January 5, 2023 13:40

reta marked this pull request as ready for review January 5, 2023 14:19

reta requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, adnapibar, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89 and tlfeng as code owners January 5, 2023 14:19

reta requested a review from xuezhou25 as a code owner January 5, 2023 14:19

reta commented Jan 5, 2023

View reviewed changes

This was referenced Jan 5, 2023

[Meta] Segment Replication flaky test failures #5669

Closed

Mute flaky test testStartReplicaAfterPrimaryIndexesDocs. #5714

Merged

mch2 approved these changes Jan 5, 2023

View reviewed changes

dreamer-89 approved these changes Jan 5, 2023

View reviewed changes

reta merged commit 3b51bc5 into opensearch-project:main Jan 6, 2023

reta added the backport 2.x Backport to 2.x branch label Jan 6, 2023

reta added a commit to reta/OpenSearch that referenced this pull request Jan 6, 2023

Update nebula-publishing-plugin to 19.2.0 (opensearch-project#5704)

5c3521f

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>

reta mentioned this pull request Jan 6, 2023

[Backport] [2.x] Update nebula-publishing-plugin to 19.2.0 (#5704) #5733

Merged

reta added a commit that referenced this pull request Jan 10, 2023

Update nebula-publishing-plugin to 19.2.0 (#5704) (#5733)

5d1680e

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>

kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023

Update nebula-publishing-plugin to 19.2.0 (#5704) (#5733)

20be9d3

Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>

mch2 added backport 1.x backport 1.3 Backport to 1.3 branch labels May 8, 2023

mch2 mentioned this pull request May 8, 2023

[Backport 1.x] Update nebula-publishing-plugin to 19.2.0 (#5704) #7471

Closed

kotwanikunal mentioned this pull request Jun 22, 2023

[Backport 1.x] Update nebula-publishing-plugin to 19.2.0 #8227

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update nebula-publishing-plugin to 19.2.0 #5704

Update nebula-publishing-plugin to 19.2.0 #5704

reta commented Jan 4, 2023 •

edited

Loading

github-actions bot commented Jan 4, 2023

reta commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 5, 2023

reta Jan 5, 2023

github-actions bot commented Jan 5, 2023

codecov-commenter commented Jan 5, 2023

mch2 commented Jan 5, 2023

opensearch-trigger-bot bot commented Jan 6, 2023

opensearch-trigger-bot bot commented May 8, 2023

opensearch-trigger-bot bot commented May 8, 2023

Update nebula-publishing-plugin to 19.2.0 #5704

Update nebula-publishing-plugin to 19.2.0 #5704

Conversation

reta commented Jan 4, 2023 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

reta Jan 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Jan 5, 2023

Codecov Report

mch2 commented Jan 5, 2023

opensearch-trigger-bot bot commented Jan 6, 2023

opensearch-trigger-bot bot commented May 8, 2023

opensearch-trigger-bot bot commented May 8, 2023

reta commented Jan 4, 2023 •

edited

Loading