Integrate remote translog download on failover

[ashking94]

Signed-off-by: Ashish Singh [email protected]

Description

Solves #5637

Issues Resolved

Solves #5637

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ashking94]

#5670 for writing integrations tests since much of the change is on integration.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/8808/
• CommitID: 3276c06

[codecov-commenter]

Codecov Report

Merging #5699 (aa4aee8) into main (01a5842) will decrease coverage by 0.06%.
The diff coverage is 93.18%.

@@             Coverage Diff              @@
##               main    #5699      +/-   ##
============================================
- Coverage     71.12%   71.05%   -0.07%     
+ Complexity    58844    58729     -115     
============================================
  Files          4767     4767              
  Lines        280162   280176      +14     
  Branches      40441    40440       -1     
============================================
- Hits         199261   199090     -171     
- Misses        64698    64813     +115     
- Partials      16203    16273      +70     

Impacted Files	Coverage Δ
...rc/main/java/org/opensearch/index/IndexModule.java	82.28% <ø> (ø)
...rg/opensearch/index/translog/RemoteFsTranslog.java	70.08% <ø> (-3.65%)	⬇️
...in/java/org/opensearch/indices/IndicesService.java	68.50% <62.50%> (-3.19%)	⬇️
...c/main/java/org/opensearch/index/IndexService.java	74.54% <100.00%> (+0.44%)	⬆️
...in/java/org/opensearch/index/shard/IndexShard.java	70.40% <100.00%> (+0.37%)	⬆️
...h/index/translog/transfer/FileTransferTracker.java	93.75% <100.00%> (+9.37%)	⬆️
...dex/translog/transfer/TranslogTransferManager.java	81.39% <100.00%> (-0.22%)	⬇️
...org/opensearch/index/shard/IndexShardTestCase.java	93.69% <100.00%> (+0.21%)	⬆️
...rch/test/junit/listeners/ReproduceInfoPrinter.java	9.52% <0.00%> (-66.67%)	⬇️
...port/ResponseHandlerFailureTransportException.java	0.00% <0.00%> (-60.00%)	⬇️
... and 479 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/8809/
• CommitID: 3a56b49

[sachinpkale]

#5670 for writing integrations tests since much of the change is on integration.

One unit test can be added to IndexShardTests. We create a shard with remote translog settings and verify class of the translog factory in the EngineConfig.

[ankitkala]

Just for my understanding, for failover, do we not need any changes in recovery path except having RemoteStoreTranslogRepository initialised properly? Or are you planning to do follow up changes?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8846/
• CommitID: 3fd0c55
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8844/
• CommitID: 7914084
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testCancelPrimaryAllocation

• URL: https://build.ci.opensearch.org/job/gradle-check/8958/
• CommitID: 3abc93d
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

• URL: https://build.ci.opensearch.org/job/gradle-check/9043/
• CommitID: aa4aee8
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5699-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32b0e618fdb3dd9bb6c83edf3498891199a43dbe
# Push it to GitHub
git push --set-upstream origin backport/backport-5699-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5699-to-2.x.