Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Validate attributes of routing nodes for Routing Weights API #5691

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Jan 4, 2023

Description

Backports #5607

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rch-project#5607)

* Changes following things in Routing Weights API and Decommission Action -
        a. Consider only routing node's attribute for validation instead of all nodes
        b. Ensure no more than 50% node has weight zero
        c. Removal of decommission action's direct dependence on force zone awareness

Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testThatMissingIndexDoesNotAbortFullBulkRequest
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testThatFailedUpdateRequestReturnsCorrectType
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testInvalidIndexNamesCorrectOpType
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testBulkUpdateWithScriptedUpsertAndDynamicMappingUpdate
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testBulkUpdateSimple
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testBulkUpdateLargerVolume
      1 org.opensearch.action.bulk.BulkWithUpdatesIT.testBulkIndexingWhileInitializing

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #5691 (9c61aaf) into 2.x (8dc5ddf) will decrease coverage by 0.01%.
The diff coverage is 92.00%.

@@             Coverage Diff              @@
##                2.x    #5691      +/-   ##
============================================
- Coverage     70.69%   70.68%   -0.02%     
- Complexity    58651    58721      +70     
============================================
  Files          4740     4740              
  Lines        280526   280542      +16     
  Branches      40883    40889       +6     
============================================
- Hits         198312   198290      -22     
- Misses        65755    65812      +57     
+ Partials      16459    16440      -19     
Impacted Files Coverage Δ
...arch/cluster/decommission/DecommissionService.java 35.88% <0.00%> (-0.91%) ⬇️
...search/cluster/routing/WeightedRoutingService.java 79.43% <92.30%> (+1.88%) ⬆️
...weighted/put/ClusterPutWeightedRoutingRequest.java 67.60% <100.00%> (+5.31%) ⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-42.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-41.47%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-41.38%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
... and 483 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Bukhtawar Bukhtawar merged commit 53a4cae into opensearch-project:2.x Jan 4, 2023
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…ts API (#5691)

* Validate attributes of routing nodes for Routing Weights API (#5607)

* Changes following things in Routing Weights API and Decommission Action -
        a. Consider only routing node's attribute for validation instead of all nodes
        b. Ensure no more than 50% node has weight zero
        c. Removal of decommission action's direct dependence on force zone awareness

Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants