Remove --enable-preview feature flag since Apache Lucene now patches class files #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
…class files Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
remove.preview.flag
branch
from
bb221b7 to
569dea7
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5642 +/- ##
============================================
- Coverage 71.02% 70.86% -0.16%
+ Complexity 58574 58534 -40
============================================
Files 4759 4759
Lines 279476 279476
Branches 40345 40345
============================================
- Hits 198484 198039 -445
- Misses 64883 65238 +355
- Partials 16109 16199 +90
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
saratvemulapalli
approved these changes
Dec 28, 2022
andrross
reviewed
Dec 28, 2022
| @@ -61,6 +61,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Changed http code on create index API with bad input raising NotXContentException from 500 to 400 ([#4773](https://github.com/opensearch-project/OpenSearch/pull/4773)) | |||
| - Change http code for DecommissioningFailedException from 500 to 400 ([#5283](https://github.com/opensearch-project/OpenSearch/pull/5283)) | |||
| - Pre conditions check before updating weighted routing metadata ([#4955](https://github.com/opensearch-project/OpenSearch/pull/4955)) | |||
| - Remove --enable-preview feature flag since Apache Lucene now patches class files ([#5642](https://github.com/opensearch-project/OpenSearch/pull/5642)) | |||
There was a problem hiding this comment.
Since the above changelog entry "Allow mmap to use new JDK-19 preview APIs" was never included a release, should the net result be the removal of that line and no new line here?
There was a problem hiding this comment.
Yeah, I think we could remove that, will take care of the changelog, thanks @andrross
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
This is follow up on [2] to remove
--enable-previewfeature flag since the latest Apache Lucene 9.5 now patches class files directly [1] to circumventpreviewflag requirements.No backport needed, this is Apache Lucene 9.5 feature
[1] https://github.com/apache/lucene/pull/12033/files
[2] #4637
Issues Resolved
Follow up on #4637
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.