-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a maintainers file based on the maintainers list that CEHENKLE posted #523
Conversation
✅ Gradle Wrapper Validation success b0386158681f168eeb96ab9e159bed9982381948 |
✅ DCO Check Passed b0386158681f168eeb96ab9e159bed9982381948 |
✅ Gradle Precommit success b0386158681f168eeb96ab9e159bed9982381948 |
Thank you @geekygirldawn Super helpful to have these contributions! I love this as a start. What do you think about adding a notation for contributors that are also Lucene committers / contributors (since Lucene is really the brains of the search) to highlight broader community involvement? |
start gradle check |
✅ Gradle Check success b0386158681f168eeb96ab9e159bed9982381948 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely good with this as the start! I am curious some thoughts on highlighting the Lucene contribution side (committers) to show sustained commitment to the core search API. We can always do that as a follow up, but I don't want to close the PR without capturing some of those thoughts here.
Typically, the maintainers file would just contain the maintainers for this particular repo. This helps new contributors understand who is likely to merge their PRs and gives them real people to follow up with if there are any issues getting their contributions merged. It might make sense to have another doc if you wanted to highlight contributions to Lucene? |
✅ Gradle Wrapper Validation success d229e466589fbf4e8294d4b95fa882ef6c1ed006 |
❌ DCO Check Failed d229e466589fbf4e8294d4b95fa882ef6c1ed006 |
✅ Gradle Precommit success d229e466589fbf4e8294d4b95fa882ef6c1ed006 |
✅ Gradle Wrapper Validation success 93e3e7e7fbc97433ace90675b46074549ffe557b |
…posted in teh forums here: https://discuss.opendistrocommunity.dev/t/preparing-opensearch-and-opensearch-dashboards-for-release/5567 Signed-off-by: Dawn M. Foster <[email protected]>
❌ DCO Check Failed 93e3e7e7fbc97433ace90675b46074549ffe557b |
✅ Gradle Wrapper Validation success d2afc90 |
✅ DCO Check Passed d2afc90 |
✅ Gradle Precommit success 93e3e7e7fbc97433ace90675b46074549ffe557b |
✅ Gradle Precommit success d2afc90 |
start gradle check |
@nknize @CEHENKLE you may consider taking a look at contributor roles used in OpenTelemetry - https://github.com/open-telemetry/community/blob/main/community-membership.md as well as using a CODEOWNERS file in each repo. See https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners |
start gradle check |
As @ke4qqq suggested, I converted the list of current maintainers found in this forum post for the OpenSearch section to a new maintainers file.
If this looks good and is merged, I can do something similar in the OpenSearch Dashboards repo.
As I mentioned in the forums, I'm also happy to help out with governance and related docs like this one :)
Signed-off-by: Dawn M. Foster [email protected]