Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for extensions #5211

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

ryanbogan
Copy link
Member

Signed-off-by: Ryan Bogan [email protected]

Description

Adds a feature flag for the functionality of extensions.

Issues Resolved

3851

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5211 (e8f7b69) into main (4fc5c8d) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5211      +/-   ##
============================================
- Coverage     71.00%   70.90%   -0.11%     
+ Complexity    58168    58117      -51     
============================================
  Files          4708     4708              
  Lines        277565   277565              
  Branches      40190    40190              
============================================
- Hits         197094   196805     -289     
- Misses        64310    64614     +304     
+ Partials      16161    16146      -15     
Impacted Files Coverage Δ
.../java/org/opensearch/common/util/FeatureFlags.java 50.00% <ø> (ø)
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-58.83%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java 27.77% <0.00%> (-41.67%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-41.38%) ⬇️
...pensearch/action/ingest/DeletePipelineRequest.java 31.25% <0.00%> (-37.50%) ⬇️
.../admin/indices/readonly/AddIndexBlockResponse.java 0.00% <0.00%> (-37.50%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 42.50% <0.00%> (-35.00%) ⬇️
... and 479 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryanbogan ryanbogan marked this pull request as ready for review November 11, 2022 00:05
@ryanbogan ryanbogan requested review from a team and reta as code owners November 11, 2022 00:05
@ryanbogan ryanbogan requested a review from dblock November 15, 2022 17:59
@ryanbogan ryanbogan merged commit 5ad8252 into opensearch-project:main Nov 15, 2022
@ryanbogan ryanbogan deleted the addExtensionsFeatureFlag branch November 15, 2022 19:46
@ryanbogan ryanbogan added the backport 2.x Backport to 2.x branch label Nov 16, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5211-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5ad8252246a599baa0477927efd59ce366b3b9ce
# Push it to GitHub
git push --set-upstream origin backport/backport-5211-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5211-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants