Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Change the output error message back to use OpenSearchException in the cause chain #5085

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d479853 from #5081.

@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners November 4, 2022 18:36
@tlfeng tlfeng added the backport PRs or issues specific to backporting features or enhancments label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

andrross commented Nov 4, 2022

@xuezhou25 Is this critical to get into 2.4? I'd rather not introduce more changes right now if we can avoid it?

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to confirm this is needed in 2.4

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 4, 2022

@andrross It's not critical, but I can imagine that some error message that shown to the user maybe changed from version 2.3 . When http.detailed_errors.enabled is set to false, previously if there is an OpenSearchException in the cause chain of an non-OpenSearchException, the simple message defined by the OpenSearchException will be shown to the user, but now the simple message will not be shown. I'm not sure if this will make inconvenience.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Gradle Check (Jenkins) Run Completed with:

…e cause chain (#5081)

Signed-off-by: Xue Zhou <[email protected]>
(cherry picked from commit d479853)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit d9e8960 into 2.4 Nov 8, 2022
@github-actions github-actions bot deleted the backport/backport-5081-to-2.4 branch November 8, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport PRs or issues specific to backporting features or enhancments skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants