Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test ResourceAwareTasksTests on windows. #5077

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Nov 4, 2022

Signed-off-by: Marc Handalian [email protected]

Description

Windows registers a cpu tick at a default of ~15ms which is slightly slower than other OSs. In CI and in most local runs the runnables in this test often complete in under that time and return a 0 value from
ThreadMXBean.getThreadCpuTime. To reduce flakiness in this test accept 0 as a value on Windows.

Issues Resolved

closes #5063

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mch2 mch2 marked this pull request as ready for review November 4, 2022 16:12
@mch2 mch2 requested review from a team and reta as code owners November 4, 2022 16:12
Signed-off-by: Marc Handalian <[email protected]>

Add Changelog entry.

Signed-off-by: Marc Handalian <[email protected]>

Revert unintentional removal of memory assertion.

Signed-off-by: Marc Handalian <[email protected]>
Copy link
Contributor

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj Poojita-Raj merged commit cce0411 into opensearch-project:main Nov 4, 2022
Poojita-Raj pushed a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 4, 2022
…t#5077)

Signed-off-by: Marc Handalian <[email protected]>

Add Changelog entry.

Signed-off-by: Marc Handalian <[email protected]>

Revert unintentional removal of memory assertion.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>
Poojita-Raj pushed a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 4, 2022
…t#5077)

Signed-off-by: Marc Handalian <[email protected]>

Add Changelog entry.

Signed-off-by: Marc Handalian <[email protected]>

Revert unintentional removal of memory assertion.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>
andrross pushed a commit that referenced this pull request Nov 4, 2022
Signed-off-by: Marc Handalian <[email protected]>

Add Changelog entry.

Signed-off-by: Marc Handalian <[email protected]>

Revert unintentional removal of memory assertion.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
andrross pushed a commit that referenced this pull request Nov 4, 2022
Signed-off-by: Marc Handalian <[email protected]>

Add Changelog entry.

Signed-off-by: Marc Handalian <[email protected]>

Revert unintentional removal of memory assertion.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj Poojita-Raj added backport 1.x backport 1.3 Backport to 1.3 branch labels Nov 16, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-5077-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cce04110d95e4266047a66fa4dc91e8fcfe0593d
# Push it to GitHub
git push --set-upstream origin backport/backport-5077-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-5077-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-5077-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cce04110d95e4266047a66fa4dc91e8fcfe0593d
# Push it to GitHub
git push --set-upstream origin backport/backport-5077-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-5077-to-1.x.

@dblock
Copy link
Member

dblock commented Nov 17, 2022

@mch2 care to backport manually?

@mch2
Copy link
Member Author

mch2 commented Nov 18, 2022

This PR doesn't need a backport to 1.x/1.3, this test was introduced in 2.x line.

@mch2 mch2 deleted the 5063 branch November 18, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ResourceAwareTasksTests flaky on Windows.
4 participants