-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test ResourceAwareTasksTests on windows. #5077
Conversation
Signed-off-by: Marc Handalian <[email protected]> Add Changelog entry. Signed-off-by: Marc Handalian <[email protected]> Revert unintentional removal of memory assertion. Signed-off-by: Marc Handalian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…t#5077) Signed-off-by: Marc Handalian <[email protected]> Add Changelog entry. Signed-off-by: Marc Handalian <[email protected]> Revert unintentional removal of memory assertion. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
…t#5077) Signed-off-by: Marc Handalian <[email protected]> Add Changelog entry. Signed-off-by: Marc Handalian <[email protected]> Revert unintentional removal of memory assertion. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian <[email protected]> Add Changelog entry. Signed-off-by: Marc Handalian <[email protected]> Revert unintentional removal of memory assertion. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Co-authored-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian <[email protected]> Add Changelog entry. Signed-off-by: Marc Handalian <[email protected]> Revert unintentional removal of memory assertion. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Co-authored-by: Marc Handalian <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-5077-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cce04110d95e4266047a66fa4dc91e8fcfe0593d
# Push it to GitHub
git push --set-upstream origin backport/backport-5077-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-5077-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cce04110d95e4266047a66fa4dc91e8fcfe0593d
# Push it to GitHub
git push --set-upstream origin backport/backport-5077-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
@mch2 care to backport manually? |
This PR doesn't need a backport to 1.x/1.3, this test was introduced in 2.x line. |
Signed-off-by: Marc Handalian [email protected]
Description
Windows registers a cpu tick at a default of ~15ms which is slightly slower than other OSs. In CI and in most local runs the runnables in this test often complete in under that time and return a 0 value from
ThreadMXBean.getThreadCpuTime. To reduce flakiness in this test accept 0 as a value on Windows.
Issues Resolved
closes #5063
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.