You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was backported in #4219 and will only be present in version 2.4 and newer. The test must be skipped for mixed cluster cases with nodes older than 2.4.
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
This feature was backported in opensearch-project#4219 and will only be present in
version 2.4 and newer. The test must be skipped for mixed cluster cases
with nodes older than 2.4.
Signed-off-by: Andrew Ross <[email protected]>
The test "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}" failed again in gradle-check 5204 and I'm not sure why. That test fails reliably without the fix in this PR locally for me, but when I apply this change I cannot reproduce the error. Not sure what is going on here...
The test "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}" failed again in gradle-check 5204 and I'm not sure why. That test fails reliably without the fix in this PR locally for me, but when I apply this change I cannot reproduce the error. Not sure what is going on here...
I see the skip is not applied in the failure cases. The the test is executed against v2.3.1 cluster.
REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v2.3.1#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}" -Dtests.seed=DA47345E5530945F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=cs -Dtests.timezone=America/St_Thomas -Druntime.java=17
NOTE: leaving temporary files on disk at: /var/jenkins/workspace/gradle-check/search/qa/mixed-cluster/build/testrun/v2.3.1#mixedClusterTest/temp/org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT_DA47345E5530945F-003
The successful run of gradle check shows that the test {p0=search/190_index_prefix_search/search with uppercase regex} was skipped as expected. I don't know why the tests were run in the failure case above. @heemin32 any idea why it ran those tests on check 5204?
Git clone: https://github.com/andrross/OpenSearch.git with ref: 852cd348675ab4f43e2492f5f6170d3c471a14df
which is the commit of this PR and seems to be correct. However, test run 5204 shows:
Git clone: https://github.com/opensearch-project/OpenSearch.git with ref: c2e6a03b741c817431a039144c98c595d04cb99b
which is an unrelated commit? Seems like some wires were crossed here. I'm going to merge this change because I think it should unblock things and open another issue about the gradle check workflow.
The successful run of gradle check shows that the test {p0=search/190_index_prefix_search/search with uppercase regex} was skipped as expected. I don't know why the tests were run in the failure case above. @heemin32 any idea why it ran those tests on check 5204?
Github bug it seems. https://build.ci.opensearch.org/job/gradle-check/5204/ is for [PR #4832](https://github.com/opensearch-project/OpenSearch/pull/4832): backport 2x exclude jettison version brought in with hadoopminicluster actually.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
andrross
force-pushed
the
uppercase-regex
branch
from
This feature was backported in #4219 and will only be present in version 2.4 and newer. The test must be skipped for mixed cluster cases with nodes older than 2.4.
Signed-off-by: Andrew Ross [email protected]
Issues Resolved
#4831
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.