-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Introduce Remote translog feature flag (#4158) #4857
Merged
andrross
merged 2 commits into
opensearch-project:2.x
from
andrross:backport/backport-4158-to-2.x
Oct 21, 2022
Merged
[Backport 2.x] Introduce Remote translog feature flag (#4158) #4857
andrross
merged 2 commits into
opensearch-project:2.x
from
andrross:backport/backport-4158-to-2.x
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI @Bukhtawar #4318 depends on this PR so I'm starting here and then will backport that change next. My immediate goal is to backport #4813 which depends on #4318. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Same failure as #4831 |
Gradle Check (Jenkins) Run Completed with:
|
andrross
force-pushed
the
backport/backport-4158-to-2.x
branch
from
October 21, 2022 15:48
0c629fb
to
07960ab
Compare
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we need the build to pass :(
* Introduce Remote translog feature flag * Limit combinations of remote segment and translog store to valid ones Signed-off-by: Bukhtawar Khan <[email protected]> (cherry picked from commit a469a3c)
Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
backport/backport-4158-to-2.x
branch
from
October 21, 2022 18:48
07960ab
to
5181ad4
Compare
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bukhtawar Khan [email protected]
(cherry picked from commit a469a3c)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.