Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Introduce Remote translog feature flag (#4158) #4857

Merged

Conversation

andrross
Copy link
Member

  • Introduce Remote translog feature flag
  • Limit combinations of remote segment and translog store to valid ones

Signed-off-by: Bukhtawar Khan [email protected]
(cherry picked from commit a469a3c)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross marked this pull request as ready for review October 20, 2022 18:56
@andrross andrross requested review from a team and reta as code owners October 20, 2022 18:56
@andrross
Copy link
Member Author

andrross commented Oct 20, 2022

FYI @Bukhtawar

#4318 depends on this PR so I'm starting here and then will backport that change next. My immediate goal is to backport #4813 which depends on #4318.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

Same failure as #4831

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross force-pushed the backport/backport-4158-to-2.x branch from 0c629fb to 07960ab Compare October 21, 2022 15:48
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need the build to pass :(

Bukhtawar and others added 2 commits October 21, 2022 11:48
* Introduce Remote translog feature flag
* Limit combinations of remote segment and translog store to valid ones

Signed-off-by: Bukhtawar Khan <[email protected]>
(cherry picked from commit a469a3c)
Signed-off-by: Andrew Ross <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 057b096 into opensearch-project:2.x Oct 21, 2022
@andrross andrross deleted the backport/backport-4158-to-2.x branch November 9, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants