Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add groupId value propagation tests for ZIP publication task #4848

Merged

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Oct 20, 2022

Description

This is back-port of #4772

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lukáš Vlček [email protected]
(cherry picked from commit eb33015)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@lukas-vlcek
Copy link
Contributor Author

Please notice that this is back-port of #4772 but I do not refer that PR number in the CHANGELOG.md file, instead I refer this new PR (which is the back-port). Let me know if I need to change this.

@lukas-vlcek
Copy link
Contributor Author

Also I think this PR will need proper labels.
Thanks you. 🙏

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@adnapibar adnapibar changed the title Add groupId value propagation tests for ZIP publication task [Backport 2.x] Add groupId value propagation tests for ZIP publication task Oct 20, 2022
@adnapibar adnapibar added the backport PRs or issues specific to backporting features or enhancments label Oct 20, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Oct 21, 2022

I believe this has been fixed in a backport of #4270, rebase?

@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Oct 21, 2022

@dblock This is a manually created back-port of #4772 because the automatic back-port failed, see #4772 (comment)

Rebased.

This is back-port of opensearch-project#4772

Signed-off-by: Lukáš Vlček <[email protected]>
(cherry picked from commit eb33015)
@lukas-vlcek lukas-vlcek force-pushed the backport/backport-4772-to-2.x branch from 3fd61be to 28d2bc5 Compare October 21, 2022 20:45
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit a273f27 into opensearch-project:2.x Oct 21, 2022
@lukas-vlcek lukas-vlcek deleted the backport/backport-4772-to-2.x branch October 23, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants