Refactor BalancedAllocator.Balancer to LocalShardsBalancer (#4761)

[kotwanikunal]

• Refactor BalancedAllocator.Balancer to LocalShardsBalancer

Signed-off-by: Kunal Kotwani [email protected]

• Deprecate Balancer to maintain BWC

Signed-off-by: Kunal Kotwani [email protected]

Signed-off-by: Kunal Kotwani [email protected]
(cherry picked from commit 1d65485)

Description

• Backports Refactor BalancedAllocator.Balancer to LocalShardsBalancer #4761 to 2.x

Issues Resolved

• Refactor BalancedAllocator.Balancer to LocalShardsBalancer #4761

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #4818 (1d65485) into 2.x (a90fd73) will increase coverage by 0.14%.
The diff coverage is 55.02%.

❗ Current head 1d65485 differs from pull request most recent head 7896384. Consider uploading reports for the commit 7896384 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #4818      +/-   ##
============================================
+ Coverage     70.62%   70.76%   +0.14%     
- Complexity    57126    57926     +800     
============================================
  Files          4585     4689     +104     
  Lines        274526   277306    +2780     
  Branches      40233    40370     +137     
============================================
+ Hits         193876   196234    +2358     
- Misses        64403    64822     +419     
- Partials      16247    16250       +3     

Impacted Files	Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java	0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy	0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java	37.36% <0.00%> (ø)
...org/opensearch/gradle/RepositoriesSetupPlugin.java	38.63% <0.00%> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java	78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java	88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java	0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java	0.00% <0.00%> (ø)
...ensearch/gradle/tar/SymbolicLinkPreservingTar.java	0.00% <0.00%> (ø)
...a/org/opensearch/gradle/test/DistroTestPlugin.java	0.00% <ø> (ø)
... and 991 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4826/
• CommitID: 41b2d9c

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4827/
• CommitID: 7896384

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4830/
• CommitID: 7896384

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4855/
• CommitID: 7896384

[kotwanikunal]

> Task :qa:mixed-cluster:v2.3.1#mixedClusterTest FAILED
build complete, generating: /var/jenkins/workspace/gradle-check/search/build/4830.tar.bz2

FAILURE: Build failed with an exception.

Task :qa:mixed-cluster:v2.3.1#mixedClusterTest FAILED failing for all with different errors. Retrying a final time.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4879/
• CommitID: 7896384

[kotwanikunal]

Unrelated failure again:

Tests with failures:
 - org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingLast
 - ```

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4883/
• CommitID: 7896384

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4894/
• CommitID: 7896384

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4974/
• CommitID: 7896384

[kotwanikunal]

🤦

FAILURE: Build failed with an exception.

* What went wrong:
Java heap space

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4981/
• CommitID: 7896384

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5000/
• CommitID: 1ede0c2