-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better plural stemmer than minimal_english #4738
Better plural stemmer than minimal_english #4738
Conversation
@markharwood - do you think this TokenFilter should eventually make it's way back into lucene? |
Gradle Check (Jenkins) Run Completed with:
|
a37e76e
to
ad69f59
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Thanks for picking this up, Nick. Yes, I think this would be a natural fit as a Lucene contribution. |
Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms. Signed-off-by: Nicholas Walter Knize <[email protected]> Co-authored-by: Mark Harwood <[email protected]> Co-authored-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
ad69f59
to
41e7377
Compare
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4738-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c92846d0ae121db54ce740790df75b36a24f804e
# Push it to GitHub
git push --set-upstream origin backport/backport-4738-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Thanks @markharwood!!! Maybe we incubate this here in OpenSearch and then look at contributing it back to lucene. Let us know if you want to contribute it back, or someone here can and we'll copy you on the PR. |
Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms. Signed-off-by: Nicholas Walter Knize <[email protected]> Co-authored-by: Mark Harwood <[email protected]> Co-authored-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit c92846d)
Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms. Signed-off-by: Nicholas Walter Knize <[email protected]> Co-authored-by: Mark Harwood <[email protected]> Co-authored-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit c92846d)
Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms. Signed-off-by: Nicholas Walter Knize <[email protected]> Co-authored-by: Mark Harwood <[email protected]> Co-authored-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit c92846d)
Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms. Signed-off-by: Nicholas Walter Knize <[email protected]> Co-authored-by: Mark Harwood <[email protected]> Co-authored-by: Nicholas Walter Knize <[email protected]>
This originated from elastic/elasticsearch#42892 originally authored by @markharwood (nice job Mark!). The PR is licensed ALv2 and never found a home in Elasticsearch. The improvements over the buggy lucene implementation are substantial so I'm opening a PR to include it in OpenSearch 2.4.