Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Adding reta to codeowners #4475

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8033183 from #2967

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner September 9, 2022 22:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

The gradle check fails during jdk 14 Adoptium installation. @peterzhuamazon @prudhvigodithi : Any ideas on how to fix this ?

java.io.IOException: Unable to locate release: jdk-14.0.2+12
	at io.jenkins.plugins.adoptopenjdk.AdoptOpenJDKInstaller.performInstallation(AdoptOpenJDKInstaller.java:109)
	at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:70)
	at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:108)
	at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:221)
	at hudson.model.JDK.forNode(JDK.java:149)
	at hudson.model.JDK.forNode(JDK.java:59)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:157)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:138)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
[Checks API] No suitable checks publisher found.
Finished: FAILURE

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peterzhuamazon
Copy link
Member

The gradle check fails during jdk 14 Adoptium installation. @peterzhuamazon @prudhvigodithi : Any ideas on how to fix this ?

java.io.IOException: Unable to locate release: jdk-14.0.2+12
	at io.jenkins.plugins.adoptopenjdk.AdoptOpenJDKInstaller.performInstallation(AdoptOpenJDKInstaller.java:109)
	at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:70)
	at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:108)
	at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:221)
	at hudson.model.JDK.forNode(JDK.java:149)
	at hudson.model.JDK.forNode(JDK.java:59)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:157)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:138)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
[Checks API] No suitable checks publisher found.
Finished: FAILURE

Fixed now, Jenkins removed the jdk14 support in auto install list, we manually add a zip now.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg
Copy link
Member

kartg commented Sep 12, 2022

Unrelated failure:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.
> Building 1.3.5 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.5-SNAPSHOT-linux-x64.tar.gz

The backport branch is up-to-date with the base branch i.e. 2.0 - diff

Will re-fire gradle check

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

dreamer-89 commented Sep 12, 2022

@kartg: I think this is happening because of 1.3 bump from 1.3.5 to 1.3.6 on 1.3 branch. PR #4381 while 2.0 have 1.3.5 as latest. The last gradle check failed with same error as the last one

This is causing problems on all 2.x branches which run bwc on latest patch on previous major version.

@dreamer-89
Copy link
Member

@kartg: I think this is happening because of 1.3 bump from 1.3.5 to 1.3.6 on 1.3 branch. PR #4381 while 2.0 have 1.3.5 as latest.

This is causing problems on all 2.x branches which run bwc on latest patch on previous major version.

Raised #4491 to fix it.

@kartg
Copy link
Member

kartg commented Sep 12, 2022

Raised #4491 to fix it.

thanks @dreamer-89 !

@dreamer-89
Copy link
Member

Raised #4491 to fix it.

thanks @dreamer-89 !

The bwc change in #4491 is merged. Can you please rebase this PR

@peterzhuamazon
Copy link
Member

Raised #4491 to fix it.

thanks @dreamer-89 !

The bwc change in #4491 is merged. Can you please rebase this PR

Rebased now.

Signed-off-by: Vacha Shah <[email protected]>
(cherry picked from commit 8033183)
@VachaShah VachaShah force-pushed the backport/backport-2967-to-2.0 branch from eab226c to 6e3f3c5 Compare September 12, 2022 23:59
@codecov-commenter
Copy link

Codecov Report

Merging #4475 (1587ef4) into 2.0 (1587ef4) will not change coverage.
The diff coverage is n/a.

❗ Current head 1587ef4 differs from pull request most recent head 6e3f3c5. Consider uploading reports for the commit 6e3f3c5 to get more accurate results

@@            Coverage Diff            @@
##                2.0    #4475   +/-   ##
=========================================
  Coverage     77.12%   77.12%           
  Complexity    62414    62414           
=========================================
  Files          4490     4490           
  Lines        271456   271456           
  Branches      40454    40454           
=========================================
  Hits         209371   209371           
  Misses        45565    45565           
  Partials      16520    16520           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

Gradle check job 2994 is failing with below error. Flaky test failure!

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.IndicesRequestCacheIT.testQueryRewriteDatesWithNow" -Dtests.seed=BF4FF97173927D58 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=Egypt -Druntime.java=17

org.opensearch.indices.IndicesRequestCacheIT > testQueryRewriteDatesWithNow FAILED
    java.lang.AssertionError: 
    Expected: <8L>
         but: was <7L>
        at __randomizedtesting.SeedInfo.seed([BF4FF97173927D58:B4DF0D1C4C791B7]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.indices.IndicesRequestCacheIT.testQueryRewriteDatesWithNow(IndicesRequestCacheIT.java:390)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

dreamer-89 commented Sep 13, 2022

Another test failure. As changes are not related to test area, refiring!

This flaky test is tracked in #4212

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections" -Dtests.seed=17E84502FA5C08FE -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ca -Dtests.timezone=Europe/Belgrade -Druntime.java=17

org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests > testReplicaThreadedUpdateToShardLimitsAndRejections FAILED
    java.lang.AssertionError: expected null, but was:<org.opensearch.index.stats.IndexingPressurePerShardStats@1921c06f>
        at __randomizedtesting.SeedInfo.seed([17E84502FA5C08FE:187071F3DADD266B]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotNull(Assert.java:756)
        at org.junit.Assert.assertNull(Assert.java:738)
        at org.junit.Assert.assertNull(Assert.java:748)
        at org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections(ShardIndexingPressureConcurrentExecutionTests.java:336)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg
Copy link
Member

kartg commented Sep 13, 2022

Thanks for persisting @dreamer-89 😎

I'll go ahead and merge this.

@kartg kartg merged commit a9e883c into 2.0 Sep 13, 2022
@kartg kartg deleted the backport/backport-2967-to-2.0 branch September 13, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants