Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Set analyzer to regex query string search #4220

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ea4cfcc from #3967

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4220 (3970b43) into 1.3 (6cabc6a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                1.3    #4220      +/-   ##
============================================
- Coverage     77.91%   77.87%   -0.04%     
+ Complexity    63474    63413      -61     
============================================
  Files          4453     4453              
  Lines        274899   274900       +1     
  Branches      41165    41163       -2     
============================================
- Hits         214189   214091      -98     
- Misses        43854    43921      +67     
- Partials      16856    16888      +32     
Impacted Files Coverage Δ
...pensearch/index/search/QueryStringQueryParser.java 76.47% <100.00%> (+0.86%) ⬆️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nsearch/indices/recovery/PeerRecoveryNotFound.java 0.00% <0.00%> (-100.00%) ⬇️
...nsearch/search/dfs/DfsPhaseExecutionException.java 0.00% <0.00%> (-66.67%) ⬇️
...ch/index/shard/ShardNotInPrimaryModeException.java 50.00% <0.00%> (-50.00%) ⬇️
.../action/ingest/SimulatePipelineRequestBuilder.java 0.00% <0.00%> (-50.00%) ⬇️
...n/indices/upgrade/post/UpgradeSettingsRequest.java 30.00% <0.00%> (-45.00%) ⬇️
...java/org/opensearch/script/ScriptContextStats.java 33.33% <0.00%> (-40.01%) ⬇️
...search/discovery/zen/PublishClusterStateStats.java 58.33% <0.00%> (-37.51%) ⬇️
...search/discovery/zen/PendingClusterStateStats.java 56.00% <0.00%> (-36.00%) ⬇️
... and 451 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AmiStrn
Copy link
Contributor

AmiStrn commented Aug 16, 2022

@andrross any idea why the DCO check would fail here? this was generated by the bot

@dblock
Copy link
Member

dblock commented Aug 16, 2022

Expected "Yogev Mets [[email protected]](mailto:[email protected])", but got "yyyogev [[email protected]](mailto:[email protected])".

🤷 The easiest is to amend this probably.

@AmiStrn
Copy link
Contributor

AmiStrn commented Aug 22, 2022

Hi @dblock !

🤷 The easiest is to amend this probably.

can I do this or is @yyyogev the only one who can amend that?

@dblock
Copy link
Member

dblock commented Aug 23, 2022

@AmiStrn I think you can replace this PR with one that has correct DCO?

Sets analyzer to regex query string search

Signed-off-by: yyyogev <[email protected]>
(cherry picked from commit ea4cfcc)

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
@dblock dblock force-pushed the backport/backport-3967-to-1.3 branch from 3970b43 to 72a8e2a Compare September 6, 2022 18:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 44c5eff into 1.3 Sep 6, 2022
@github-actions github-actions bot deleted the backport/backport-3967-to-1.3 branch September 6, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants