-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Added HostAddress and Port in initial extension request #4197
[Feature/extensions] Added HostAddress and Port in initial extension request #4197
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4197 +/- ##
========================================================
- Coverage 70.63% 70.58% -0.05%
+ Complexity 57186 57175 -11
========================================================
Files 4625 4625
Lines 275465 275473 +8
Branches 40289 40291 +2
========================================================
- Hits 194570 194439 -131
- Misses 64564 64714 +150
+ Partials 16331 16320 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions inline.
server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
57422db
to
c758db9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
c758db9
to
7ff48ac
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java
Show resolved
Hide resolved
Ugh, I probably should have finished my review of opensearch-project/opensearch-sdk-java#67 first. I don't think any of these changes are necessary.... but now it's merged. :| |
…tension request (opensearch-project#4197)" This reverts commit 60bb959. Signed-off-by: Daniel Widdis <[email protected]>
…tension request (#4197)" (#4277) This reverts commit 60bb959. Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Owais Kazi [email protected]
Description
Added HostAddress and Port in initial extension request for SDKClient to run.
Issues Resolved
Part of opensearch-project/opensearch-sdk-java#66
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.