Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Added HostAddress and Port in initial extension request #4197

Merged

Conversation

owaiskazi19
Copy link
Member

Signed-off-by: Owais Kazi [email protected]

Description

Added HostAddress and Port in initial extension request for SDKClient to run.

Issues Resolved

Part of opensearch-project/opensearch-sdk-java#66

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #4197 (7ff48ac) into feature/extensions (e3acafd) will decrease coverage by 0.04%.
The diff coverage is 18.18%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4197      +/-   ##
========================================================
- Coverage                 70.63%   70.58%   -0.05%     
+ Complexity                57186    57175      -11     
========================================================
  Files                      4625     4625              
  Lines                    275465   275473       +8     
  Branches                  40289    40291       +2     
========================================================
- Hits                     194570   194439     -131     
- Misses                    64564    64714     +150     
+ Partials                  16331    16320      -11     
Impacted Files Coverage Δ
...nsearch/discovery/InitializeExtensionsRequest.java 35.71% <18.18%> (-4.29%) ⬇️
...opensearch/index/mapper/MockFieldFilterPlugin.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/opensearch/search/dfs/AggregatedDfs.java 51.61% <0.00%> (-45.17%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 35.71% <0.00%> (-35.72%) ⬇️
...ava/org/opensearch/search/dfs/DfsSearchResult.java 43.26% <0.00%> (-35.58%) ⬇️
...ensearch/client/indices/DetailAnalyzeResponse.java 20.54% <0.00%> (-34.25%) ⬇️
...ndex/query/functionscore/DecayFunctionBuilder.java 33.45% <0.00%> (-32.37%) ⬇️
...search/search/aggregations/pipeline/EwmaModel.java 24.44% <0.00%> (-31.12%) ⬇️
.../java/org/opensearch/index/reindex/RemoteInfo.java 50.45% <0.00%> (-29.36%) ⬇️
... and 494 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@owaiskazi19 owaiskazi19 changed the title Added HostAddress and Port in initial extension request [Feature/extensions] Added HostAddress and Port in initial extension request Aug 12, 2022
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions inline.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19 owaiskazi19 merged commit 60bb959 into opensearch-project:feature/extensions Aug 22, 2022
@dbwiddis
Copy link
Member

Ugh, I probably should have finished my review of opensearch-project/opensearch-sdk-java#67 first. I don't think any of these changes are necessary.... but now it's merged. :|

dbwiddis added a commit to dbwiddis/OpenSearch that referenced this pull request Aug 22, 2022
owaiskazi19 pushed a commit that referenced this pull request Aug 22, 2022
…tension request (#4197)" (#4277)

This reverts commit 60bb959.

Signed-off-by: Daniel Widdis <[email protected]>

Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants