Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Rishikesh1159 · 2022-07-07T23:07:13Z

Signed-off-by: Rishikesh1159 [email protected]

Description

This PR removes incorrect heading of breaking change in 3773, we incorrectly put one of the heading as Breaking changes. Breaking changes should be released only in major versions. This PR also removes one PR from 2.1.0 release notes which was reverted.
[Describe what this change achieves]

Issues Resolved

#3773

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…as reverted Signed-off-by: Rishikesh1159 <[email protected]>

dreamer-89 · 2022-07-07T23:13:18Z

release-notes/opensearch.release-notes-2.1.0.md

@@ -67,7 +63,6 @@
 * Removing unused method from TransportSearchAction (#3437) ([#3445](https://github.com/opensearch-project/opensearch/pull/3445))
 * Fix Lucene-snapshots repo for jdk 17. (#3396) ([#3404](https://github.com/opensearch-project/opensearch/pull/3404))
 * Temporary adding Apache Lucene repositories for snapshots (#3042) ([#3047](https://github.com/opensearch-project/opensearch/pull/3047))
-* [Remove] MainResponse version override cluster setting (#3031) ([#3032](https://github.com/opensearch-project/opensearch/pull/3032))


Comparing to previous minor relesae (2.0) this change was missing and added back in patch 2.0.1. So, if we are basing changes on 2.0, we should include it.

#3530 is missing here then that reverts this removal.

As @mch2 mentioned #3530 reverts this change. Discussed offline with @mch2 decided to leave out this commit

gaiksaya · 2022-07-07T23:22:30Z

release-notes/opensearch.release-notes-2.1.0.md

-### Breaking Changes in 2.1.0
-
-#### Remove Mapping types
+### Remove Mapping types


This should not be a category but rather under some category. More details: https://github.com/opensearch-project/opensearch-plugins/blob/main/RELEASE_NOTES.md#categories
same applies to all below major headings (upgrades, deprecations)

Got it. Let me change their categories

If this is not a breaking change can we please put it to either bug fixes or enhancements?

Yes that makes sense

github-actions · 2022-07-07T23:57:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/295/
CommitID: a80bf33

codecov-commenter · 2022-07-07T23:57:47Z

Codecov Report

❗ No coverage uploaded for pull request base (main@c08e5ac). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3817   +/-   ##
=======================================
  Coverage        ?   70.55%           
  Complexity      ?    56669           
=======================================
  Files           ?     4557           
  Lines           ?   272681           
  Branches        ?    40038           
=======================================
  Hits            ?   192393           
  Misses          ?    64004           
  Partials        ?    16284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08e5ac...a80bf33. Read the comment docs.

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2022-07-08T01:08:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/299/
CommitID: 70b2bdf

github-actions · 2022-07-08T01:30:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/300/
CommitID: 63df4aa

github-actions · 2022-07-08T02:21:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/305/
CommitID: 63df4aa

github-actions · 2022-07-08T03:40:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/306/
CommitID: 63df4aa

github-actions · 2022-07-08T04:16:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/307/
CommitID: 63df4aa

opensearch-trigger-bot · 2022-07-08T18:04:14Z

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3817-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 23004bdbb0e874e1679f30b89146797caa6ba47a
# Push it to GitHub
git push --set-upstream origin backport/backport-3817-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-3817-to-2.1.

…#3817) * Removing Incorrect heading of release notes. Removing unnecessary categories and move commits to other categories Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 23004bd)

…#3817) (#3833) * Removing Incorrect heading of release notes. Removing unnecessary categories and move commits to other categories Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 23004bd) Co-authored-by: Rishikesh Pasham <[email protected]>

Removing Incorrect heading of release notes and removing a PR which w…

a80bf33

…as reverted Signed-off-by: Rishikesh1159 <[email protected]>

Rishikesh1159 requested review from a team and reta as code owners July 7, 2022 23:07

Rishikesh1159 mentioned this pull request Jul 7, 2022

Add release notes for version 2.1.0 #3773

Merged

5 tasks

dreamer-89 reviewed Jul 7, 2022

View reviewed changes

mch2 approved these changes Jul 7, 2022

View reviewed changes

gaiksaya reviewed Jul 7, 2022

View reviewed changes

Rishikesh1159 added 2 commits July 8, 2022 00:03

Removing unnecessary categories

70b2bdf

Signed-off-by: Rishikesh1159 <[email protected]>

Removing unnecessary categories and move commits to other categories

63df4aa

Signed-off-by: Rishikesh1159 <[email protected]>

gaiksaya approved these changes Jul 8, 2022

View reviewed changes

gaiksaya mentioned this pull request Jul 8, 2022

Add OpenSearch release notes link opensearch-project/opensearch-build#2318

Merged

Rishikesh1159 merged commit 23004bd into opensearch-project:main Jul 8, 2022

Rishikesh1159 added the backport 2.1 label Jul 8, 2022

Rishikesh1159 added backport 2.1 and removed backport 2.1 labels Jul 8, 2022

opensearch-trigger-bot bot mentioned this pull request Jul 8, 2022

[Backport 2.1] Removing Incorrect heading of breaking changes in 2.1.0 release notes #3833

Merged

dblock mentioned this pull request Jul 9, 2022

Automate CHANGELOG generation acm19/aws-request-signing-apache-interceptor#48

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Rishikesh1159 commented Jul 7, 2022

dreamer-89 Jul 7, 2022 •

edited

Loading

mch2 Jul 7, 2022

Rishikesh1159 Jul 8, 2022

gaiksaya Jul 7, 2022 •

edited

Loading

Rishikesh1159 Jul 7, 2022

peterzhuamazon Jul 7, 2022

Rishikesh1159 Jul 8, 2022

github-actions bot commented Jul 7, 2022

codecov-commenter commented Jul 7, 2022

github-actions bot commented Jul 8, 2022

github-actions bot commented Jul 8, 2022

github-actions bot commented Jul 8, 2022

github-actions bot commented Jul 8, 2022

github-actions bot commented Jul 8, 2022

opensearch-trigger-bot bot commented Jul 8, 2022

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Conversation

Rishikesh1159 commented Jul 7, 2022

Description

Issues Resolved

Check List

dreamer-89 Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

mch2 Jul 7, 2022

Choose a reason for hiding this comment

Rishikesh1159 Jul 8, 2022

Choose a reason for hiding this comment

gaiksaya Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

Rishikesh1159 Jul 7, 2022

Choose a reason for hiding this comment

peterzhuamazon Jul 7, 2022

Choose a reason for hiding this comment

Rishikesh1159 Jul 8, 2022

Choose a reason for hiding this comment

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Jul 7, 2022

Codecov Report

github-actions bot commented Jul 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 8, 2022

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Jul 8, 2022

dreamer-89 Jul 7, 2022 •

edited

Loading

gaiksaya Jul 7, 2022 •

edited

Loading