Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.0] Gradle plugin opensearch.pluginzip Add implicit dependency. #3212

Merged
merged 1 commit into from
May 7, 2022
Merged

[Backport 2.0] Gradle plugin opensearch.pluginzip Add implicit dependency. #3212

merged 1 commit into from
May 7, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2fe2e37 from #3189

@prudhvigodithi @github-actions
Gradle plugin opensearch.pluginzip Add implicit dependency. (#3189)
eca47ff 
* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add implicit dependency

Signed-off-by: pgodithi <[email protected]>

* Add dependsOn

Signed-off-by: pgodithi <[email protected]>
(cherry picked from commit 2fe2e37)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner May 5, 2022 21:13
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure eca47ff
Log 5055

Reports 5055

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure eca47ff
Log 5063

Reports 5063

@dblock
Copy link
Member

dblock commented May 6, 2022

Doesn't look like a fluke

> Task :distribution:bwc:bugfix:buildBwcLinuxTar FAILED
> Task :distribution:archives:buildNoJdkDarwinArm64Tar

cc: @prudhvigodithi

@prudhvigodithi
Copy link
Member

Hey @dblock on my local /gradlew precommit --parallel passed, but ya ./gradlew :distribution:bwc:bugfix:buildBwcLinuxTar actually failed
Error:

> Task :distribution:bwc:bugfix:buildBwcLinuxTar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 1.3.2 didn't generate expected file /tmp/OpenSearch/distribution/bwc/bugfix/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.2-SNAPSHOT-linux-x64.tar.gz

@peterzhuamazon @bbarani

@dblock
Copy link
Member

dblock commented May 6, 2022

start gradle check

@tlfeng
Copy link
Collaborator

tlfeng commented May 6, 2022 •
edited
Loading

Hi @prudhvigodithi, I hope the test failure of :distribution:bwc:bugfix:buildBwcLinuxTar is resolved by the commit bb1d88b, which just merged into 2.0 branch.

@prudhvigodithi
Copy link
Member

Hi @prudhvigodithi, I hope the test failure of :distribution:bwc:bugfix:buildBwcLinuxTar is resolved by the commit bb1d88b, which just merged into 2.0 branch.

Hey @tlfeng got it, ya after adding those changes, passed in my local as well.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success eca47ff
Log 5112

Reports 5112

@peterzhuamazon peterzhuamazon merged commit 12157a8 into 2.0 May 7, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-3189-to-2.0 branch May 7, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartg kartg kartg approved these changes

@nknize nknize nknize approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@opensearch-ci-bot @peterzhuamazon @dblock @prudhvigodithi @tlfeng @reta @nknize @kartg