-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the replication type index setting, alongside a formal notion of feature flags #3037
Changes from 2 commits
ae9fcfd
f9153c4
8bda19d
25901f4
e5c27c9
5b5a946
2001ed8
bb7afbb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,32 @@ | ||||||
/* | ||||||
* SPDX-License-Identifier: Apache-2.0 | ||||||
* | ||||||
* The OpenSearch Contributors require contributions made to | ||||||
* this file be licensed under the Apache-2.0 license or a | ||||||
* compatible open source license. | ||||||
*/ | ||||||
|
||||||
package org.opensearch.common.util; | ||||||
|
||||||
/** | ||||||
* Utility class to manage feature flags. Feature flags are system properties that must be set on the JVM. | ||||||
* These are used to gate the visibility/availability of incomplete features. Fore more information, see | ||||||
* https://featureflags.io/feature-flag-introduction/ | ||||||
*/ | ||||||
public class FeatureFlags { | ||||||
|
||||||
/** | ||||||
* Gates the visibility of the index setting that enables segment replication. | ||||||
* Once the feature is ready for production release, this feature flag can be removed. | ||||||
*/ | ||||||
public static final String SEGREP_FEATURE_FLAG = "opensearch.segment_replication_feature_flag_enabled"; | ||||||
nknize marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
/** | ||||||
* Used to test feature flags whose values are expected to be booleans. | ||||||
* This method returns true if the value is "true" (case-insensitive), | ||||||
* and false otherwise. | ||||||
*/ | ||||||
public static boolean isEnabled(String featureFlagName) { | ||||||
return "true".equalsIgnoreCase(System.getProperty(featureFlagName)); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
It might be nice to auto enable for snapshot builds? Doing this, though, will most certainly fail the FeatureFlag tests the way they are currently written. |
||||||
} | ||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -530,6 +530,7 @@ public final class IndexSettings { | |
private final String nodeName; | ||
private final Settings nodeSettings; | ||
private final int numberOfShards; | ||
private final Boolean isSegRepEnabled; | ||
// volatile fields are updated via #updateIndexMetadata(IndexMetadata) under lock | ||
private volatile Settings settings; | ||
private volatile IndexMetadata indexMetadata; | ||
|
@@ -681,6 +682,7 @@ public IndexSettings(final IndexMetadata indexMetadata, final Settings nodeSetti | |
nodeName = Node.NODE_NAME_SETTING.get(settings); | ||
this.indexMetadata = indexMetadata; | ||
numberOfShards = settings.getAsInt(IndexMetadata.SETTING_NUMBER_OF_SHARDS, null); | ||
isSegRepEnabled = settings.getAsBoolean(IndexMetadata.SETTING_SEGMENT_REPLICATION, false); | ||
|
||
this.searchThrottled = INDEX_SEARCH_THROTTLED.get(settings); | ||
this.queryStringLenient = QUERY_STRING_LENIENT_SETTING.get(settings); | ||
|
@@ -915,6 +917,13 @@ public int getNumberOfReplicas() { | |
return settings.getAsInt(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, null); | ||
} | ||
|
||
/** | ||
* Returns true if segment replication is enabled on the index. | ||
*/ | ||
public boolean isSegrepEnabled() { | ||
return Boolean.TRUE.equals(isSegRepEnabled); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can just be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry, I'll stop commenting until you move this out of draft :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic in this method has changed with the latest commit - That said, I do like Also, feel free to leave early comments - I think this change is just about finalized anyway |
||
} | ||
|
||
/** | ||
* Returns the node settings. The settings returned from {@link #getSettings()} are a merged version of the | ||
* index settings and the node settings where node settings are overwritten by index settings. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note -
Map.of
is only available from Java 9+There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be an issue since we have to remain 11+ due to lucene 9.