Remove JavaVersion, use builtin Runtime.Version to deal with runtime versions #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions Signed-off-by: Andriy Redko <[email protected]>
|
Labelled to backport to 2.x but not 2.0. LMK if you feel otherwise. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 20, 2022
…versions (#3006) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 3b7e654)
dblock
pushed a commit
that referenced
this pull request
Apr 20, 2022
…versions (#3006) (#3013) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 3b7e654) Co-authored-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Since JDK-9, the JDK provide standard means to manipulate runtime version using
RuntimeandRuntime.Version. It makes sense to removeJavaVersionin favour of standardRuntime.Version.Also, since 2.0 sets JDK-11 as baseline, we could drop all checks for JDK-8/9/10
Issues Resolved
Closes #3003
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.