-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed java11 source folders since JDK-11 is the baseline now #2898
Conversation
@dblock please when you have time, thanks! |
❌ Gradle Check failure 22a18d9c38e1cbe4fdde94c10388d591aa0fcfdd |
Signed-off-by: Andriy Redko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx!
@dblock apologies, I could not add labels to backport it to 2.0, may I ask you please to add those? |
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d61d170)
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d61d170)
@saratvemulapalli you are very right, the labels (and other settings) are available to me now (but were not available before), thanks for highlighting that! |
#2952) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d61d170) Co-authored-by: Andriy Redko <[email protected]>
#2953) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d61d170) Co-authored-by: Andriy Redko <[email protected]>
The java11-specific sources were removed back in opensearch-project#2898 and as far as I can tell this configuration has been unneeded since that point. Signed-off-by: Andrew Ross <[email protected]>
The java11-specific sources were removed back in #2898 and as far as I can tell this configuration has been unneeded since that point. Signed-off-by: Andrew Ross <[email protected]>
The java11-specific sources were removed back in #2898 and as far as I can tell this configuration has been unneeded since that point. Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit a3524b3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The java11-specific sources were removed back in #2898 and as far as I can tell this configuration has been unneeded since that point. (cherry picked from commit a3524b3) Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The java11-specific sources were removed back in opensearch-project#2898 and as far as I can tell this configuration has been unneeded since that point. Signed-off-by: Andrew Ross <[email protected]>
The java11-specific sources were removed back in opensearch-project#2898 and as far as I can tell this configuration has been unneeded since that point. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Andriy Redko [email protected]
Description
Removed java11 source folders since JDK-11 is the baseline now (also unblocks unnecessary Jacoco customizations to workaround jacoco/jacoco#407).
Issues Resolved
Part of https://github.com/opensearch-project/OpenSearch/pull/2821/files
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.