Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PIT API #2745
Create PIT API #2745
Changes from 9 commits
469738f
0d1f337
751c320
eba05e5
130a597
c6f9398
87ec605
f8f6367
0fcd1df
3002c20
1f6f466
de5c4e4
3359986
232179e
730afa8
4747018
7340feb
eec2480
b87f0fd
939fafc
02c7537
c6cef2b
bd0105c
35d8cc4
11c5195
471a64a
47bb3e7
c28762e
f272405
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also mention that we are deleting a pit in the partial failure scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all 3 - create, delete, list PIT transport layers invoke the same "PITController" class rather than having 3 separate classes(I presume that's what was planned based on the naming of this class).
All PIT crud operation logic could be handled from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes to have all together in single controller but found that nothing is reusable across APIs. The request, listeners etc are different and accepts different params and gives different responses. So reverted it back to having different controllers for different flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this setting in SearchService? Shouldn't this setting be in TransportCreatePITAction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a proper description detailing why this search is being executed
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task description already contains pit details which is relevant to this operation , do we need more info ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-private? We just need for functional testing right?