Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file to dir in Environment #2730

Merged

Conversation

ruanwenjun
Copy link
Contributor

Description

I find a TODO in Environment, this pr is used to fix this TODO.

Issues Resolved

Rename some method ended with file to dir, e.g. configFile to configDir.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruanwenjun ruanwenjun requested a review from a team as a code owner April 4, 2022 10:14
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 74508f8
Log 4100

Reports 4100

@dblock
Copy link
Member

dblock commented Apr 5, 2022

Looks like legit build failures:

> Task :example-plugins:custom-settings:compileJava FAILED
/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/plugins/examples/custom-settings/src/main/java/org/opensearch/example/customsettings/ExampleCustomSettingsConfig.java:99: error: cannot find symbol
        final Path configDir = environment.configFile();
                                          ^
  symbol:   method configFile()
  location: variable environment of type Environment
1 error

Signed-off-by: ruanwenjun <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b4434a1
Log 4173

Reports 4173

Signed-off-by: ruanwenjun <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ff7e704
Log 4182

Reports 4182

@tlfeng tlfeng added the v3.0.0 Issues and PRs related to version 3.0.0 label Apr 5, 2022
@dblock dblock merged commit 0b1f4a2 into opensearch-project:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants