Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Bug] Fix InboundDecoder version compat check #2574

Merged
merged 4 commits into from
Mar 24, 2022
Merged

[Backport 2.x] [Bug] Fix InboundDecoder version compat check #2574

merged 4 commits into from
Mar 24, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 511ac88 from #2570

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 23, 2022 18:27
@nknize
[Bug] Fix InboundDecoder version compat check (#2570)
4035a68 
Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit version check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 511ac88)
@nknize nknize force-pushed the backport/backport-2570-to-2.x branch from ae700c1 to 4035a68 Compare March 23, 2022 18:29
nknize
nknize approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added DCO sign-off and LGTM

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ae700c19e52737c4a22b13a7d46b2a52dce6e023
Log 3705

Reports 3705

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4035a68
Log 3708

Reports 3708

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7a712d5
Log 3712

Reports 3712

@nknize nknize mentioned this pull request Mar 23, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b4b190e
Log 3720

Reports 3720

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4239622
Log 3729

Reports 3729

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022 •
edited
Loading

non-reproducible Integ Test Failure:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.aliases.IndexAliasesIT.testSameAlias" -Dtests.seed=D759B90667E7AFC3 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sl -Dtests.timezone=Etc/GMT+12 -Druntime.java=17

  2> java.lang.AssertionError: AcknowledgedResponse failed - not acked
    Expected: <true>
         but: was <false>
        at __randomizedtesting.SeedInfo.seed([D759B90667E7AFC3:551A0CCCC00FF5E5]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked(OpenSearchAssertions.java:127)
        at org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked(OpenSearchAssertions.java:115)
        at org.opensearch.aliases.IndexAliasesIT.lambda$testSameAlias$52(IndexAliasesIT.java:803)
        at org.opensearch.aliases.IndexAliasesIT.assertAliasesVersionIncreases(IndexAliasesIT.java:1489)
        at org.opensearch.aliases.IndexAliasesIT.assertAliasesVersionIncreases(IndexAliasesIT.java:1480)
        at org.opensearch.aliases.IndexAliasesIT.testSameAlias(IndexAliasesIT.java:801)

Looks like a test fluke? Keeping an eye out for recurring and will need triaging if this becomes pathological

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022

start gradle check

@nknize nknize mentioned this pull request Mar 24, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4239622
Log 3730

Reports 3730

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022

another #2311 failure; refiring

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4239622
Log 3731

Reports 3731

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022

Now a #1703 failure!
Refiring!

@nknize
Copy link
Collaborator

nknize commented Mar 24, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4239622
Log 3732

Reports 3732

@nknize nknize merged commit 388b02b into 2.x Mar 24, 2022
@github-actions github-actions bot deleted the backport/backport-2570-to-2.x branch March 24, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @nknize