Updates to segrep classes to mirror refactoring in main #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class now simply extends GatedAutoCloseable and its constructor invokes the superclass. Signed-off-by: Kartik Ganesh <[email protected]>
As with the now-deleted IndexCommitRef class, this wrapper class is not needed. It has been replaced with a GatedCloseable instance wrapping a SegmentInfos Signed-off-by: Kartik Ganesh <[email protected]>
|
Can one of the admins verify this patch? |
kartg
commented
Mar 10, 2022
server/src/main/java/org/opensearch/indices/replication/copy/ReplicationCollection.java
Show resolved
Hide resolved
mch2
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR comprises two changes:
ReplicationRefclass to mirrorRecoveryRefand simply be an extension ofGatedAutoCloseable.Issues Resolved
closes #2202
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.