Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Reintroduce negative epoch_millis #1991 #2314

Closed
wants to merge 1 commit into from
Closed

[Backport 1.x] Reintroduce negative epoch_millis #1991 #2314

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4b89410 from #2232

@br3no @github-actions
Reintroduce negative epoch_millis #1991 (#2232)
f2d4532 
* Reintroduce negative epoch_millis #1991

Fixes a regression introduced with Elasticsearch 7 regarding the date
field type that removed support for negative timestamps with sub-second
granularity.

Thanks to Ryan Kophs (https://github.com/rkophs) for allowing me to use
his previous work.

Signed-off-by: Breno Faria <[email protected]>

* applying spotless fix

Signed-off-by: Breno Faria <[email protected]>

* more conservative implementation of isSupportedBy

Signed-off-by: Breno Faria <[email protected]>

* adding braces to control flow statement

Signed-off-by: Breno Faria <[email protected]>

* spotless fix...

Signed-off-by: Breno Faria <[email protected]>

Co-authored-by: Breno Faria <[email protected]>
(cherry picked from commit 4b89410)
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f2d4532
Log 2937

Reports 2937

@dblock
Copy link
Member

dblock commented Mar 2, 2022

@VachaShah What's the guidance for noreply.github.com in DCO? What should @br3no do?

@VachaShah
Copy link
Collaborator

@VachaShah What's the guidance for noreply.github.com in DCO? What should @br3no do?

@br3no's email might be private, so the backport workflow would not be able read the email and the DCO app won't be able to read it. dcoapp/app#134

The commit would need to be manually amended with the sign off, or a manual backport :|

@br3no
Copy link
Contributor

br3no commented Mar 3, 2022

I have changed my email settings.

@dblock
Copy link
Member

dblock commented Mar 3, 2022

@br3no Could you please manually backport this one?

@VachaShah
Copy link
Collaborator

Hi @dblock, I will try to re-run the backport workflow to create this PR again since @br3no has updated the email settings. If that doesn't work, manual backport it is.

@VachaShah VachaShah closed this Mar 3, 2022
@VachaShah VachaShah deleted the backport/backport-2232-to-1.x branch March 3, 2022 19:48
@VachaShah
Copy link
Collaborator

Well, the bot raised the a new backport #2328 but the DCO still fails since it would be attached to the commit I think. @br3no manual backport it is then, sorry :|

@VachaShah VachaShah mentioned this pull request Mar 3, 2022
Closed
@br3no
Copy link
Contributor

br3no commented Mar 4, 2022 •
edited
Loading

Okay, so let me see if I get the workflow right:

  1. create a new backport/backport-1991-to-1 branch based on 1.x
  2. cherry-pick the merged commit from main
  3. open pull request in github

Is this correct? @VachaShah @dblock

@dblock
Copy link
Member

dblock commented Mar 4, 2022

Okay, so let me see if I get the workflow right:

  1. create a new backport/backport-1991-to-1 branch based on 1.x
  2. cherry-pick the merged commit from main
  3. open pull request in github

Is this correct? @VachaShah @dblock

Yep!

@br3no
Copy link
Contributor

br3no commented Mar 7, 2022

@dblock, I opened #2380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opensearch-ci-bot @dblock @VachaShah @br3no