Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to JDK 11. #2301

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Downgrade to JDK 11. #2301

merged 5 commits into from
Mar 2, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 1, 2022

Signed-off-by: dblock [email protected]

Description

We have 4 issues with attempting to upgrade JDK to 17 in 1.3.0 as part of opensearch-project/opensearch-plugins#64.

This downgrades 1.x to JDK 11.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cb418e1bba44d4576f791eced119b0449981751a
Log 2905

Reports 2905

@reta
Copy link
Collaborator

reta commented Mar 1, 2022

@dblock I will take a look why version is not accepted (I think it is expected as x.y.z+n, but there are 4 components now)

@dblock
Copy link
Member Author

dblock commented Mar 1, 2022

@dblock I will take a look why version is not accepted (I think it is expected as x.y.z+n, but there are 4 components now)

For now I dropped .1 in the PR.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c42140e19ebe2e193237a87295dcf94d631fccdd
Log 2906

Reports 2906

Signed-off-by: dblock <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 3b33594
Log 2907

Reports 2907

@reta
Copy link
Collaborator

reta commented Mar 1, 2022

@dblock I will take a look why version is not accepted (I think it is expected as x.y.z+n, but there are 4 components now)

For now I dropped .1 in the PR.

Opened dblock#29 to your branch

dblock added 2 commits March 1, 2022 17:00
Added support for patch JDK version, like 11.0.14+1
Signed-off-by: dblock <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 33c7ac3
Log 2908

Reports 2908

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d9809ed
Log 2909

Reports 2909

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure eaf5738
Log 2910

Reports 2910

@dblock
Copy link
Member Author

dblock commented Mar 1, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure eaf5738
Log 2911

Reports 2911

@reta
Copy link
Collaborator

reta commented Mar 1, 2022

�[91mErrors during downloading metadata for repository 'appstream':
|   - Curl error (28): Timeout was reached for http://vault.centos.org/centos/8/AppStream/x86_64/os/repodata/repomd.xml [Connection timed out after 30000 milliseconds]
|   - Curl error (28): Timeout was reached for http://vault.centos.org/centos/8/AppStream/x86_64/os/repodata/repomd.xml [Connection timed out after 30001 millisecond

:(

@dblock
Copy link
Member Author

dblock commented Mar 2, 2022

start gradle check

@dblock dblock marked this pull request as ready for review March 2, 2022 14:19
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success eaf5738
Log 2930

Reports 2930

@dblock dblock requested a review from saratvemulapalli March 2, 2022 18:06
@dblock dblock merged commit 5114528 into opensearch-project:1.x Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants