Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url #2086

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url #2086

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bd18b0
Override Default Distribution Download Url with Custom Distribution U…
Rishikesh1159 Feb 10, 2022
ae4806d
Adding test to check if correct IVY repos were added
Rishikesh1159 Feb 11, 2022
5944093
Adding another test case when custom url is not passed and documentin…
Rishikesh1159 Feb 16, 2022
00d8023
Adding TOC and making changes in DEVELOPER_GUIDE
Rishikesh1159 Feb 16, 2022
17bcb6a
Making changes in DEVELOPER_GUIDE about Distribution Download plugin
Rishikesh1159 Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions DEVELOPER_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,15 @@ somehow. OpenSearch plugins use this configuration to include dependencies that
Code that is on the classpath for compiling tests that are part of this project but not production code. The canonical example
of this is `junit`.

### Gradle Plugins

#### Distribution Download Plugin

We can override the default distribution download url which always downloads latest version of OpenSearch, with custom distribution download url. This will help to pull artifacts from any location.
This custom distribution download url can be passed from external plugins as an argument.

Sample command: ./gradlew integTest -DcustomDistributionUrl= "custom distribution download url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking a bit. This is a doc, so instead of "we can override ..." write "To override ..." and instead of "This will help" with "This enables to ..." or "This allows to pull artifacts from a custom location."

url -> URL

Remove "Sample command: ", quote the example on its own line, and replace "custom distribution download url" with an actual URL that one might want to use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will make these changes.


## Misc

### git-secrets
Expand Down
4 changes: 4 additions & 0 deletions buildSrc/src/test/java/org/opensearch/gradle/DistributionDownloadPluginTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ public void testCustomDistributionUrlWithoutUrl() {
((DefaultIvyArtifactRepository) project.getRepositories().getAt("opensearch-downloads")).getUrl().toString(),
"https://artifacts.opensearch.org"
);
assertEquals(
((DefaultIvyArtifactRepository) project.getRepositories().getAt("opensearch-downloads2")).getUrl().toString(),
"https://artifacts.opensearch.org"
);
assertEquals(
((DefaultIvyArtifactRepository) project.getRepositories().getAt("opensearch-snapshots")).getUrl().toString(),
"https://artifacts.opensearch.org"
Expand Down