Changes to enable “shouldForward” gating #2084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a shouldForward operation to the ReplicationOperation.PrimaryResult interface. This is used by the logic in ReplicationOperation to gate forwarding of the request to replicas. The TransportReplicationAction.PrimaryResult subclass incorporates a member variable to store this value. The value is eventually populated by the WritePrimaryResult constructor, based on a new IndexShard API. This API internally depends on the segment-replication setting. Meanwhile, other implementing classes just use a defuault hard-coded implementation to maintain backwards compatibility. Signed-off-by: Kartik Ganesh <[email protected]>
|
Can one of the admins verify this patch? |
|
The changes in this PR aren't necessary for building the initial portions of segment replication, so I'm going to abandon this change. Instead, I'll focus on improving the changes proposed in the POC PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a shouldForward operation to the ReplicationOperation.PrimaryResult interface. This is used by the logic in ReplicationOperation to gate forwarding of the request to replicas. The TransportReplicationAction.PrimaryResult subclass incorporates a member variable to store this value. The value is eventually populated by the WritePrimaryResult constructor, based on a new IndexShard API. This API internally depends on the segment-replication setting.
Meanwhile, other implementing classes just use a defuault hard-coded implementation to maintain backwards compatibility.
Signed-off-by: Kartik Ganesh [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.