Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name correction to follow existing convention #1874

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

tylermcvaney
Copy link
Contributor

@tylermcvaney tylermcvaney commented Jan 10, 2022

Updated the name of the file to follow existing naming conventions. I discovered this due to the 1.2.3 hyperlink on "/docs/1.2/version-history/" being broken.

@tylermcvaney tylermcvaney requested a review from a team as a code owner January 10, 2022 22:00
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 436153e5c0104a324ab28226fb8483684b444d68
Log 1840

Reports 1840

@dblock
Copy link
Member

dblock commented Jan 11, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 436153e5c0104a324ab28226fb8483684b444d68
Log 1849

Reports 1849

@dblock
Copy link
Member

dblock commented Jan 11, 2022

@tylermcvaney You'll need to amend your commit with -s for the DCO check.

@tylermcvaney
Copy link
Contributor Author

@tylermcvaney You'll need to amend your commit with -s for the DCO check.

Apologies for messing this up, @dblock . I read over the Contributing to OpenSearch page and managed to miss the DCO portion. I used the GitHub web interface to make the pull request and do not appear to have the ability to amend the commit. I see now that I could have manually added the DCO string in my commit description.

I am new to this process, so I want to avoid making anything worse. If someone could provide me some direction on how to resolve this current problem (having issues amending the commit), I will make sure to not make the same mistake in the future. I want to become a more active member in the OS community.

@dblock
Copy link
Member

dblock commented Jan 12, 2022

@tylermcvaney You'll need to amend your commit with -s for the DCO check.

Apologies for messing this up, @dblock . I read over the Contributing to OpenSearch page and managed to miss the DCO portion. I used the GitHub web interface to make the pull request and do not appear to have the ability to amend the commit. I see now that I could have manually added the DCO string in my commit description.

I am new to this process, so I want to avoid making anything worse. If someone could provide me some direction on how to resolve this current problem (having issues amending the commit), I will make sure to not make the same mistake in the future. I want to become a more active member in the OS community.

No worries! Let me try to help. Try this:

  1. Clone the code locally, e.g. git clone [email protected]:tylermcvaney/OpenSearch-1.git (might need to be https://github.com/tylermcvaney/OpenSearch-1.git)
  2. cd OpenSearch-1
  3. git checkout patch-1
  4. git commit --amend -s, save
  5. git push origin patch-1 -f

Updated the name of the file to follow existing naming conventions. I discovered this due to the 1.2.3 hyperlink on "/docs/1.2/version-history/" being broken.

Signed-off-by: Tyler McVaney <[email protected]>
@tylermcvaney
Copy link
Contributor Author

@tylermcvaney You'll need to amend your commit with -s for the DCO check.

Apologies for messing this up, @dblock . I read over the Contributing to OpenSearch page and managed to miss the DCO portion. I used the GitHub web interface to make the pull request and do not appear to have the ability to amend the commit. I see now that I could have manually added the DCO string in my commit description.
I am new to this process, so I want to avoid making anything worse. If someone could provide me some direction on how to resolve this current problem (having issues amending the commit), I will make sure to not make the same mistake in the future. I want to become a more active member in the OS community.

No worries! Let me try to help. Try this:

  1. Clone the code locally, e.g. git clone [email protected]:tylermcvaney/OpenSearch-1.git (might need to be https://github.com/tylermcvaney/OpenSearch-1.git)
  2. cd OpenSearch-1
  3. git checkout patch-1
  4. git commit --amend -s, save
  5. git push origin patch-1 -f

@dblock that appears to have worked. Many thanks for helping me learn something new!

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure df3eda4
Log 1896

Reports 1896

@dblock
Copy link
Member

dblock commented Jan 13, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success df3eda4
Log 1907

Reports 1907

@dblock dblock merged commit 0f31d62 into opensearch-project:main Jan 13, 2022
@dblock dblock added backport 1.x pending backport Identifies an issue or PR that still needs to be backported labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants