Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rule based autotagging] add attribute value store #17342

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[rule based autotagging] add attribute value store #17342

wants to merge 8 commits into from

Conversation

kaushalmahi12
Copy link
Contributor

@kaushalmahi12 kaushalmahi12 commented Feb 12, 2025 •
edited
Loading

Description

This change will allow us to store prefix based string values in-memory structures. This will be fundamental to process Rules or any prefix based structure in memory.

Changes in this PR

  • It introduces an interface for allowing prefix based string manipulation
  • It adds a Patricia Trie based implementation of the above interface and includes UTs

Related Issues

#16797 (comment)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaushalmahi12
add CHANGELOG entry
f575fbd 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12 kaushalmahi12 added the backport 2.x Backport to 2.x branch label Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f575fbd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk
jainankitk reviewed Feb 14, 2025
View reviewed changes
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java Outdated Show resolved Hide resolved
...agement/src/main/java/org/opensearch/plugin/wlm/rule/storage/DefaultAttributeValueStore.java Outdated Show resolved Hide resolved
...agement/src/main/java/org/opensearch/plugin/wlm/rule/storage/DefaultAttributeValueStore.java Outdated Show resolved Hide resolved
...agement/src/main/java/org/opensearch/plugin/wlm/rule/storage/DefaultAttributeValueStore.java Outdated Show resolved Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java Show resolved Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java Outdated Show resolved Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 630a3ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 630a3ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3f98f9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ec2938e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1150c37: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d02e544: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
Copy link
Contributor Author

Unrelated test failure:

org.opensearch.cluster.metadata.MetadataCreateIndexServiceTests.testCreateIndexWithContextDisabled

This was referenced Feb 18, 2025
Closed
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d339697: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 18, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1d4530f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 45764ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 149ac0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 19, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 147ab2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
add licenses directory
9645e41 
Signed-off-by: Kaushal Kumar <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9645e41: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgup432 sgup432 sgup432 left review comments

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalmahi12 @jainankitk @sgup432