Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for append only indices #17039

Merged

Conversation

RS146BIJAY
Copy link
Contributor

@RS146BIJAY RS146BIJAY commented Jan 16, 2025

Description

Adding support for Append only indices where we are disabling any form of updates and deletes on the index. We are also preventing passing a custom doc id for bulk indexing requests. Append only indices will be supported through a configurable setting. If this setting is enabled, all update and delete operations on the index (UPDATE, DELETE, UPSERT, UPDATE BY QUERY, DELETE BY QUERY, etc,) will be blocked.

Related Issues

#12886

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 38061f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@RS146BIJAY RS146BIJAY marked this pull request as ready for review January 17, 2025 10:31
@RS146BIJAY RS146BIJAY changed the title Adding support for append only indices Add support for append only indices Jan 17, 2025
Copy link
Contributor

❌ Gradle check result for 7af2713: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@mgodwan mgodwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If indexing into lucene ever causes the version to be greater than 1, should we fail the shard?

Copy link
Contributor

❌ Gradle check result for 8004cab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 8870b45: SUCCESS

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 43.47826% with 39 lines in your changes missing coverage. Please review.

Project coverage is 72.25%. Comparing base (e6fc600) to head (1acf39b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/action/bulk/TransportBulkAction.java 13.04% 18 Missing and 2 partials ⚠️
...earch/action/bulk/BulkPrimaryExecutionContext.java 42.10% 10 Missing and 1 partial ⚠️
...va/org/opensearch/index/engine/InternalEngine.java 61.90% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17039      +/-   ##
============================================
- Coverage     72.34%   72.25%   -0.10%     
- Complexity    65481    65487       +6     
============================================
  Files          5300     5302       +2     
  Lines        304330   304574     +244     
  Branches      44141    44183      +42     
============================================
- Hits         220158   220057     -101     
- Misses        66093    66478     +385     
+ Partials      18079    18039      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RS146BIJAY RS146BIJAY added backport 2.x Backport to 2.x branch v2.19.0 Issues and PRs related to version 2.19.0 labels Jan 28, 2025
Copy link
Contributor

✅ Gradle check result for 331fc41: SUCCESS

@RS146BIJAY RS146BIJAY force-pushed the append-only-indices branch 2 times, most recently from e5cef6d to 9051853 Compare January 28, 2025 11:03
Copy link
Contributor

✅ Gradle check result for 1acf39b: SUCCESS

@RS146BIJAY
Copy link
Contributor Author

Code coverage is taken care by Integ test cases

@shwetathareja shwetathareja merged commit 5e12737 into opensearch-project:main Jan 28, 2025
29 of 31 checks passed
@shwetathareja
Copy link
Member

@RS146BIJAY we will need documentation PR for the new setting

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
Signed-off-by: RS146BIJAY <[email protected]>
(cherry picked from commit 5e12737)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@RS146BIJAY
Copy link
Contributor Author

@RS146BIJAY we will need documentation PR for the new setting

Ack. Will raise a separate documentation PR.

linuxpi pushed a commit that referenced this pull request Jan 28, 2025
(cherry picked from commit 5e12737)

Signed-off-by: RS146BIJAY <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
etolbakov pushed a commit to etolbakov/OpenSearch that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.19.0 Issues and PRs related to version 2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants