-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for append only indices #17039
Add support for append only indices #17039
Conversation
❌ Gradle check result for 38061f7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
38061f7
to
7af2713
Compare
❌ Gradle check result for 7af2713: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If indexing into lucene ever causes the version to be greater than 1, should we fail the shard?
libs/common/src/main/java/org/opensearch/common/IndexingRetryException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/action/bulk/AppendOnlyIndicesIT.java
Outdated
Show resolved
Hide resolved
7af2713
to
694c524
Compare
752972a
to
8004cab
Compare
❌ Gradle check result for 8004cab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
8004cab
to
8870b45
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17039 +/- ##
============================================
- Coverage 72.34% 72.25% -0.10%
- Complexity 65481 65487 +6
============================================
Files 5300 5302 +2
Lines 304330 304574 +244
Branches 44141 44183 +42
============================================
- Hits 220158 220057 -101
- Misses 66093 66478 +385
+ Partials 18079 18039 -40 ☔ View full report in Codecov by Sentry. |
8870b45
to
286678a
Compare
286678a
to
331fc41
Compare
server/src/internalClusterTest/java/org/opensearch/action/bulk/AppendOnlyIndicesIT.java
Show resolved
Hide resolved
e5cef6d
to
9051853
Compare
Signed-off-by: RS146BIJAY <[email protected]>
9051853
to
1acf39b
Compare
Code coverage is taken care by Integ test cases |
5e12737
into
opensearch-project:main
@RS146BIJAY we will need documentation PR for the new setting |
Signed-off-by: RS146BIJAY <[email protected]> (cherry picked from commit 5e12737) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Ack. Will raise a separate documentation PR. |
(cherry picked from commit 5e12737) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Eugene Tolbakov <[email protected]>
Description
Adding support for Append only indices where we are disabling any form of updates and deletes on the index. We are also preventing passing a custom doc id for bulk indexing requests. Append only indices will be supported through a configurable setting. If this setting is enabled, all update and delete operations on the index (UPDATE, DELETE, UPSERT, UPDATE BY QUERY, DELETE BY QUERY, etc,) will be blocked.
Related Issues
#12886
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.