Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 7. Fixing 'eclipse' plugin dependencies #1648

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 2, 2021

Signed-off-by: Andriy Redko [email protected]

Description

The eclipse plugin fails with:

...
> Task :test:fixtures:hdfs-fixture:eclipseJdt                                                                                                                                                
Execution optimizations have been disabled for task ':test:fixtures:hdfs-fixture:eclipseJdt' to ensure correctness due to the following reasons:                                             
  - Gradle detected a problem with the following location: '/home/andriy.redko/Workspaces/Experiments/OpenSearch/test/fixtures/hdfs-fixture/.settings/org.eclipse.jdt.core.prefs'. Reason: Ta
sk ':test:fixtures:hdfs-fixture:eclipseJdt' uses this output of task ':test:fixtures:hdfs-fixture:copyEclipseSettings' without declaring an explicit or implicit dependency. This can lead to
 incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for mor
e details about this problem.                                                                 
Gradle detected a problem with the following location: '/home/andriy.redko/Workspaces/Experiments/OpenSearch/test/fixtures/hdfs-fixture/.settings/org.eclipse.jdt.core.prefs'. Reason: Task '
:test:fixtures:hdfs-fixture:eclipseJdt' uses this output of task ':test:fixtures:hdfs-fixture:copyEclipseSettings' without declaring an explicit or implicit dependency. This can lead to inc
orrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for more de
tails about this problem. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradl
e.org/7.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
...

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner December 2, 2021 21:11
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 2c07ae3

@reta
Copy link
Collaborator Author

reta commented Dec 2, 2021

@dblock whenever you have time please

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 2c07ae3

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 2c07ae3
Log 1306

Reports 1306

Copy link
Contributor

@setiah setiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though i'm not a gradle expert :))!

@VachaShah
Copy link
Collaborator

Does this need to be backported to 1.x? If so, you can add backport 1.x label to this PR and re-run the workflows. Once the backport workflow runs on this PR, this PR can be merged to main and the workflow will create a backport PR automatically.

@reta
Copy link
Collaborator Author

reta commented Dec 3, 2021

@VachaShah the backport PR is here #1622, it includes this change as well, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants