-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable coordinator search.request_stats_enabled by default #16290
Conversation
Signed-off-by: David Zane <[email protected]>
❌ Gradle check result for ffaed5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16290 +/- ##
============================================
- Coverage 72.06% 71.93% -0.13%
+ Complexity 64822 64734 -88
============================================
Files 5308 5307 -1
Lines 302574 302540 -34
Branches 43710 43708 -2
============================================
- Hits 218048 217643 -405
- Misses 66648 66999 +351
- Partials 17878 17898 +20 ☔ View full report in Codecov by Sentry. |
@dzane17 does this need any documentation updates (see checklist in first comment) |
@dbwiddis I checked the nodes stats API documentation. We don't specify default values so no doc PR is needed. https://opensearch.org/docs/latest/api-reference/nodes-apis/nodes-stats/ |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88d13eb5bd3bbea3a04b7b0c7576ca00d0f8435c
# Push it to GitHub
git push --set-upstream origin backport/backport-16290-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@dzane17 can you please do a manual backport? |
…h-project#16290) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]> (cherry picked from commit 88d13eb)
…16320) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]> (cherry picked from commit 88d13eb)
…h-project#16290) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
…h-project#16290) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
…h-project#16290) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
…h-project#16290) Signed-off-by: David Zane <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
Description
Enable coordinator
search.request_stats_enabled
by defaultRelated Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.