-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IndicesRequestCacheIT flaky tests #16276
Conversation
Signed-off-by: Sagar Upadhyaya <[email protected]>
❌ Gradle check result for 10c3dd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an attempt to fix. How are we tracking the follow-up (does this work? If not should we revert?)
@sgup432 - Seems you're missing the lucene version upgrade changes from main:
|
Signed-off-by: Sagar Upadhyaya <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16276 +/- ##
============================================
- Coverage 72.06% 71.99% -0.07%
+ Complexity 64822 64789 -33
============================================
Files 5308 5308
Lines 302574 302565 -9
Branches 43710 43710
============================================
- Hits 218048 217845 -203
- Misses 66648 66841 +193
- Partials 17878 17879 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sagar Upadhyaya <[email protected]> (cherry picked from commit 20536ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 20536ee) Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Description
This makes an attempt to fix two flaky test in IndicesRequestCacheIT mentioned here
I was not able to reproduce this even when running these tests for more than 500 iterations. So pretty rare. But the fix is based on a pretty good assumption that it will work. Also considering experience with fixing such similar tests successfully in the past.
Details below:
SearchTimeoutIT
which works fine.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.