Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Indexing] Ensure support of the new transport by security plugin #13174

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 12, 2024

Description

Continuing work on supporting secure transports for all OpenSearch core transport modules and plugins, adding secure transport support to Reactor Netty 4 transport.

Related Issues

Resolves #9068

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 12, 2024
@reta reta requested a review from peternied as a code owner April 12, 2024 17:21
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Compatibility status:

Checks if related components are compatible with change 0e2ebe8

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 1921646: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.57%. Comparing base (b15cb0c) to head (0e2ebe8).
Report is 162 commits behind head on main.

Files Patch % Lines
...actor/netty4/ReactorNetty4HttpServerTransport.java 69.23% 8 Missing ⚠️
...g/opensearch/http/reactor/netty4/ssl/SslUtils.java 0.00% 7 Missing ⚠️
...nsearch/transport/reactor/ReactorNetty4Plugin.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13174      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.15%     
- Complexity    59978    60695     +717     
============================================
  Files          4985     5040      +55     
  Lines        282275   285371    +3096     
  Branches      40946    41328     +382     
============================================
+ Hits         201603   204250    +2647     
- Misses        63999    64222     +223     
- Partials      16673    16899     +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for a4b5bef: SUCCESS

Copy link
Contributor

❌ Gradle check result for 0e2ebe8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Apr 15, 2024

❌ Gradle check result for 0e2ebe8: FAILURE

#12197
#13046

Copy link
Contributor

❕ Gradle check result for 0e2ebe8: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peternied
Copy link
Member

@reta Thanks for creating this PR, I'll try to review this shortly

@peternied peternied merged commit 6afbcd4 into opensearch-project:main Apr 15, 2024
30 of 31 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Apr 16, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13174-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6afbcd40e72ec0a0ff6d3e28d5a3e0773a7fb741
# Push it to GitHub
git push --set-upstream origin backport/backport-13174-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13174-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Streaming Indexing] Ensure support of the new transport by security plugin
2 participants