Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled mockTelemetryPlugin for IT and fixed OOM #13054

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

atharvasharma61
Copy link
Contributor

@atharvasharma61 atharvasharma61 commented Apr 3, 2024

Description

PR to test OOM fix during ITs. Since a lot of spans are generated during the testing, by default, we are disabling the stackTraceElement data from the MockSpanData which aims to significantly reduce the memory usage. It can be re-enabled manually if needed for debugging purposes.

Related Issues

Resolves #12615

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Compatibility status:

Checks if related components are compatible with change 82d63bc

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Apr 3, 2024

✅ Gradle check result for c4fc0f9: SUCCESS

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (b15cb0c) to head (ceb20cc).
Report is 187 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13054      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.15%     
- Complexity    59978    60758     +780     
============================================
  Files          4985     5040      +55     
  Lines        282275   285416    +3141     
  Branches      40946    41335     +389     
============================================
+ Hits         201603   204294    +2691     
- Misses        63999    64256     +257     
- Partials      16673    16866     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for 6ec2e3f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ Gradle check result for d9ed2f9: SUCCESS

Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for 2e921a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ Gradle check result for 272a439: SUCCESS

@atharvasharma61
Copy link
Contributor Author

@reta Can you please check if it looks good?

Copy link
Contributor

❕ Gradle check result for 82d63bc: UNSTABLE

  • TEST FAILURES:
      3 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for 15629fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ceb20cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 16db035: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testRestartPrimary_NoReplicas

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta added the backport 2.x Backport to 2.x branch label Apr 17, 2024
@reta
Copy link
Collaborator

reta commented Apr 17, 2024

❌ Gradle check result for ceb20cc: FAILURE

#13240

@reta
Copy link
Collaborator

reta commented Apr 17, 2024

❌ Gradle check result for 15629fc: FAILURE

#13240

Copy link
Contributor

❕ Gradle check result for ceb20cc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit 51009b7 into opensearch-project:main Apr 17, 2024
33 of 34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13054-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51009b76d480ac5b03b667b6282a987d0695ca2f
# Push it to GitHub
git push --set-upstream origin backport/backport-13054-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13054-to-2.x.

@reta
Copy link
Collaborator

reta commented Apr 17, 2024

@atharvasharma61 could you please backport to 2.x manually? thank you

@atharvasharma61 atharvasharma61 deleted the span-map-oom branch April 17, 2024 19:12
@atharvasharma61 atharvasharma61 restored the span-map-oom branch April 17, 2024 19:12
atharvasharma61 added a commit to atharvasharma61/OpenSearch that referenced this pull request Apr 17, 2024
…13054)

* Disable stackTrace in MockSpanData by default

Signed-off-by: Atharva Sharma <[email protected]>

* enabled MockTelemetryPlugin for ITs

Signed-off-by: Atharva Sharma <[email protected]>

* Added the flag as system property

Signed-off-by: Atharva Sharma <[email protected]>

* Applied java spotless check

Signed-off-by: Atharva Sharma <[email protected]>

* Added details in changelog

Signed-off-by: Atharva Sharma <[email protected]>

* Added details in TESTING.md

Signed-off-by: Atharva Sharma <[email protected]>

* Update TESTING.md

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 51009b7)
reta pushed a commit that referenced this pull request Apr 17, 2024
* Disable stackTrace in MockSpanData by default

Signed-off-by: Atharva Sharma <[email protected]>

* enabled MockTelemetryPlugin for ITs

Signed-off-by: Atharva Sharma <[email protected]>

* Added the flag as system property

Signed-off-by: Atharva Sharma <[email protected]>

* Applied java spotless check

Signed-off-by: Atharva Sharma <[email protected]>

* Added details in changelog

Signed-off-by: Atharva Sharma <[email protected]>

* Added details in TESTING.md

Signed-off-by: Atharva Sharma <[email protected]>

* Update TESTING.md

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 51009b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working flaky-test Random test failure that succeeds on second run Other
Projects
None yet
5 participants