-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated assert in test #12616
Remove duplicated assert in test #12616
Conversation
This line can be safely removed because the two lines following this assert test exactly the same condition. Signed-off-by: Lukáš Vlček <[email protected]>
This change does not require a |
Compatibility status:Checks if related components are compatible with change faca1fa Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for faca1fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Added in a label to skip changelog. |
❕ Gradle check result for faca1fa: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12616 +/- ##
============================================
- Coverage 71.42% 71.37% -0.05%
- Complexity 59978 59997 +19
============================================
Files 4985 4985
Lines 282275 282337 +62
Branches 40946 40952 +6
============================================
- Hits 201603 201530 -73
- Misses 63999 64148 +149
+ Partials 16673 16659 -14 ☔ View full report in Codecov by Sentry. |
ef9314e
into
opensearch-project:main
This line can be safely removed because the two lines following this assert test exactly the same condition. Signed-off-by: Lukáš Vlček <[email protected]> (cherry picked from commit ef9314e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This line can be safely removed because the two lines following this assert test exactly the same condition. (cherry picked from commit ef9314e) Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This line can be safely removed because the two lines following this assert test exactly the same condition. Signed-off-by: Lukáš Vlček <[email protected]>
This line can be safely removed because the two lines following this assert test exactly the same condition. Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This line can be safely removed because the two lines following this assert test exactly the same condition.
Related Issues
n/a
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.